Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 809053003: Presubmit for chrome/browser/resources matches multiline metric types. (Closed)

Created:
6 years ago by gayane -on leave until 09-2017
Modified:
5 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Presubmit for chrome/browser/resources matches multiline metric type. Also added a testcase for it and a nice print of errors. BUG=443026 Committed: https://crrev.com/940df072ba1d09a1095d3c67bb5d06d6b1a4ba02 Cr-Commit-Position: refs/heads/master@{#317794}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M PRESUBMIT_test_mocks.py View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/PRESUBMIT_test.py View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
gayane -on leave until 09-2017
Please have a look.
6 years ago (2014-12-18 19:53:38 UTC) #3
michaelpg
lgtm, it fixes the issue but I can't be sure this works for everything.
6 years ago (2014-12-19 21:49:04 UTC) #4
gayane -on leave until 09-2017
dbeam@chromium.org: Please have a look for owners review -PRESUBMIT.py -PRESUBMIT_test.py
5 years, 12 months ago (2014-12-22 16:54:09 UTC) #6
Dan Beam
lgtm
5 years, 11 months ago (2014-12-31 02:01:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809053003/1
5 years, 11 months ago (2014-12-31 06:48:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/32852)
5 years, 11 months ago (2014-12-31 06:54:34 UTC) #11
gayane -on leave until 09-2017
phajdan.jr@chromium.org: Would you do the owners review for PRESUBMIT_test_mocks.py.
5 years, 11 months ago (2015-01-07 15:46:22 UTC) #12
Paweł Hajdan Jr.
https://codereview.chromium.org/809053003/diff/1/PRESUBMIT_test_mocks.py File PRESUBMIT_test_mocks.py (right): https://codereview.chromium.org/809053003/diff/1/PRESUBMIT_test_mocks.py#newcode57 PRESUBMIT_test_mocks.py:57: return self.message Why is this needed?
5 years, 11 months ago (2015-01-07 16:41:12 UTC) #13
gayane -on leave until 09-2017
On 2015/01/07 16:41:12, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/809053003/diff/1/PRESUBMIT_test_mocks.py > File PRESUBMIT_test_mocks.py (right): > > ...
5 years, 11 months ago (2015-01-07 16:57:15 UTC) #14
michaelpg
ping: although the regexes aren't perfect, this is a step in the right direction, right?
5 years, 10 months ago (2015-02-24 07:27:20 UTC) #15
Paweł Hajdan Jr.
LGTM
5 years, 9 months ago (2015-02-24 13:18:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809053003/1
5 years, 9 months ago (2015-02-24 14:18:35 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-24 14:28:37 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-02-24 14:29:13 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/940df072ba1d09a1095d3c67bb5d06d6b1a4ba02
Cr-Commit-Position: refs/heads/master@{#317794}

Powered by Google App Engine
This is Rietveld 408576698