gsutil: Use urllib2 instead of urllib.

gsutil: Use urllib2 instead of urllib.

This is similar to r247914 and r149742: urllib does not work with SSL
connections behind proxies, we need to use urllib2 instead. Doing this
should allow people behind proxies to download gsutils 4.7 after
r293413.

(Setting NOTRY here to be able to land the issue, otherwise the CQ fails when running some presubmit checks, see crbug.com/443232)

R=maruel@chromium.org, hinoka@chromium.org, pgervais@chromium.org, primiano@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293439

[Primiano Tucci (use gerrit), 2014-12-17 15:57:14]

This patch makes sense to me but I'm not an owner of depot tools.

[M-A Ruel, 2014-12-17 16:01:45]

lgtm

https://codereview.chromium.org/809053002/diff/1/gsutil.py
File gsutil.py (right):

https://codereview.chromium.org/809053002/diff/1/gsutil.py#newcode9
gsutil.py:9: import argparse
Ugh, can you sort the list while at it? Thanks.

[Raphael Kubo da Costa (rakuco), 2014-12-17 16:18:41]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2014-12-17 16:18:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809053002/20001

[commit-bot: I haz the power, 2014-12-17 16:25:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 16:25:36]

Presubmit check for 809053002-20001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (113 files) (119.72s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:41: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module android
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module blink
W: 13, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module ios
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module presubmit_unittest
E:2003, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2003, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2003, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2020, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2020, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2020, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2377, 4: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2396, 4: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2636, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)


tests/gsutil_test.py (1.83s) failed
FEEE.
======================================================================
ERROR: test_download_gsutil (__main__.GsutilUnitTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gsutil_test.py", line 80, in tearDown
    self.assertEqual(self.fake.expectations, [])
AssertionError: Lists differ: [(('https://storage.googleapis... != []

First list contains 1 additional elements.
First extra element 0:
(('https://storage.googleapis.com/pub/gsutil_4.2.zip',), {}, <__main__.Buffer
object at 0x1de5e50>)

+ []
- [(('https://storage.googleapis.com/pub/gsutil_4.2.zip',),
-   {},
-   <__main__.Buffer object at 0x1de5e50>)]

======================================================================
ERROR: test_ensure_gsutil_full (__main__.GsutilUnitTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gsutil_test.py", line 148, in test_ensure_gsutil_full
    gsutil.InvalidGsutilError, gsutil.ensure_gsutil, version, self.tempdir)
  File "/usr/lib/python2.7/unittest/case.py", line 471, in assertRaises
    callableObj(*args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/gsutil.py",
line 116, in ensure_gsutil
    if not check_gsutil(gsutil_bin):
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/gsutil.py",
line 92, in check_gsutil
    call([sys.executable, gsutil_bin, 'version'], verbose=False)
  File "tests/gsutil_test.py", line 64, in __call__
    raise TestError(message)
TestError: Expected:
  args: ('https://storage.googleapis.com/pub/gsutil_4.2.zip',)
  kwargs: {}
Got:
  args: (['/usr/bin/python', '/tmp/tmpKLSSLB/gsutil_4.2/gsutil/gsutil',
'version'],)
  kwargs: {'verbose': False}


======================================================================
ERROR: test_ensure_gsutil_full (__main__.GsutilUnitTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gsutil_test.py", line 80, in tearDown
    self.assertEqual(self.fake.expectations, [])
AssertionError: Lists differ: [((['/usr/bin/python', '/tmp/t... != []

First list contains 1 additional elements.
First extra element 0:
((['/usr/bin/python', '/tmp/tmpKLSSLB/gsutil_4.2/gsutil/gsutil', 'version'],),
{'verbose': False}, SubprocessError())

+ []
- [((['/usr/bin/python', '/tmp/tmpKLSSLB/gsutil_4.2/gsutil/gsutil',
'version'],),
-   {'verbose': False},
-   SubprocessError())]

======================================================================
FAIL: test_download_gsutil (__main__.GsutilUnitTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gsutil_test.py", line 97, in test_download_gsutil
    self.assertEquals(fake_file, f.read())
AssertionError: 'This is gsutil.zip' !=
'PK\x03\x04\n\x00\x00\x00\x00\x00\x8ae\xc5D\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x07\x00\x1c\x00gsutil/UT\t\x00\x03\x93\xc8\x90S\x93\xc8\x90Sux\x0b\x00\x01\x04{\xd6\x02\x00\x04\x88\x13\x00\x00PK\x03\x04\x14\x00\x00\x00\x08\x00Vd\xc5D\xbb7\x8c\xbb\x0c=\x00\x00\x85\xb4\x00\x00\x11\x00\x1c\x00gsutil/CHANGES.mdUT\t\x00\x03S\xc6\x90S\x93\xc8\x90Sux\x0b\x00\x01\x04{\xd6\x02\x00\x04\x88\x13\x00\x00\xb5\xbd\xebr\xdcH\x92%\xfc\x9fO\x01c\xcf.\xc92"y\xd1\xa5\xaaT3\xbd\xa3\xa2X*n\xeb6\xa2\xd4\xdd;\xb664$\x80\xccD\x0b\td\xe1B*\xeb\xd7\xbc\xc6\x9a\xed\xbe\xdc<\xc9\xfa\xf1KD\x00\x99)\x91=\x9a\xb1\xef\xdb.1\x81@\\<<\xdc\x8f\x1f\xf7x\x9f\x97y\xd2\xe6\xd1\xe3\xc9yt\xd8\xe8?\xb2\xa4\xcb\x9fE\xe7\xa7g\x8f\xe3\xd3\xa7\xf1\xe9\x93\xa3\xbd\x7f\xba\xdf\xff\xed\xed\xbd\xc9\xef\xa2_\xf2\xa4\xeb\x9b\xbc\xdd\x8b\x83\xff\xdb\x8b\xa3\xe7Y\x96g\xd1*i\x92\xb2\xcc\xcb\xa8\xcb\xdb.\xca?\xe7i\xdf\x15u\x15\xb5\xfdjU7]\xd4\xd5\xf2KZ/\x97I\x95\x1d\xd3#\xcf\xa2\xfdyKO\x95Q\xbc\xe4\x1f\xf7\xf7\xf6~\xee\xe7\xd1/\xc5\xe7\xf0+\xf4\t\xfaK4K\x8a\x92>\x1fe}ST\xf3\xa8\xc9\xbbf\x1d\xd5\xb3(\xa9\xa2\xbf\xbe~\x15e\xf5]U\xd6I6\xa1\xc7_\xd7\xb7\xd4#\xfa\xe2\xb4\xa6\xff\xc7\x86\x7f>9\xffqr\x16\xcd\x8a\xcfx\x9f\x7fJ\xfan\x91W]\x91&\xdc\xd7\xbci\xea*\xaf\xfb\xb6\\\xefE\xf4\x1e:\x8eg\xdf>\xa7\xe7\xce\xa3\xb4\xc93<\x9d\x94m\x94\xb4QQ\xdd&e\xc1\x1fD\xff\xdc\x04\xd0\x08Wu[ty\xd4\xaf\xd0\xa36\xba\xa3\x8fD}\x8b\xa6\xea\xaa\\GI\x84\xff.\xf3h\xd5\xd4i\xdeRk\x15uw\xd1\xe4\x89kmV\xd0\xcfi\xbdZG\xb3\xa6^F/\xeb\x1a\xcf_\x94u\x9fE\xd7]\xdd$\xf3<\x8a\xff\x18]?\x8afu\xc3O\xb7\xd1\x9c\x1a\xe8\xf2\x86ZJ*\xea\xff\x0f\x7f\xfa\x99\xfaH\x9f\xfa=\xb7Vm\xbe\x93\x94\xba\xb9\xd8\x8f\xee\x8an\x11=/\xcb\x8fm\xde\xb4\x115D\xff\xfd\xdc\xcfI\x9e\xc9\x0f\xf3\xa6\xeeW\xad5\xd2\xd6K\xed\x1a\xe6\x8b~\xbek\n\x9e\xa6\x8a\x84\xa4,*\xea\t\x16{\x91G\xb4\xd0\xc5\x0c\x8b\x8e\xfe\x8d\xfb\xc0\x0b\x8ee\xec\x9b\x8a\x9a\xcbr\xbcE\x13\xb2\xca\x1b\x9a\xa2i\x1e\x9dF,>)fh\xb2\xb7\xf7\x96Zl\xa2\x0b\x1a\xdb|$\x83\x90\x10k5]E\xf1\xef\xfbQU\xdfE\xc5\xbc\xaaI\\i\xf6i-\xdaU\x92\xe6\x98\x0e\xf4+\xff\xdc\xe5U\x8b\x15/\x8b\xb6\xa3\xb6\xdf\xbb\xedr\xb6}\xbb<\x89\xcf\x7fx\xc0v\xd9)\xc5$\x96I4\xa5_\xa9\'_\x16\x98&\xf8\x17\xad\x12\xadg\xfe\x99:\x8by\xe6\xe7+Z#\xfa\xa9\xee\xcb\x8c\xb7\x86\x97\xfby\xda\xc65$\xfb<\x86\x90\xc7\xab\xb2\x9fc\xe0utK\x8b\x89Q\x9fM\x9e\x1c\xdb>p\xdd\xc1\xc4\xbc[\xbf+"\x99I\xfa`F\xdfk\x8a\xa9\xecc\x12\xaaN?\x97&=M\x8f-c\x1d\xf5U\x95c\x91\x92\xa6\x80pw]\xbe\\\xf1\x86\xff\xad\xcf\x1b\xec$4m\x12L}\xefi\xa4\x97\x15\xf5\x89$$\xef\x12\x9ag\xda\x10ys[\xa4\xf9W\xd7\xf9\xdd\xeeI\xab\xea\xa8\xac\xe9\xa5&jWyZ\xcc\xd6P\r\xc5,\xae\xea.^&]\xba
\xe9\xca\xd3\xba\xca\n\x0c\x88\xba%\xdb\x92\xdf\x1eL+V\xa6cq\xbf\xd7\xd7\xd2\xa4L\xfb\x92\x84\x85\xe6\xf2\xe2\xfd\xc5\xa3\xf34Z$-\xbeV\xd0\x8e\xeaj\xfa\xd2\xce\x8fD\x874Z\x9a\xcc\x84\x96\x9b\x16\xb7,#\xd6)\xd8z\xd1\x94\x07\xf0\xfa\xc5\x13n\xee\x08\xfdy\x9f/y\x89\x93U\xd1\xd55\xa9\xa1,_\xe5\x15)\xa5t\x8d\xcd2\x9f\x95\xc9\xbc\x1d\xc8\xf3\xe9Ny\xfe\xfe\x01\xf2\xfc:\xf9\x1b\r\x05\x87\xc0KY\xf5?\xab$\xc5\xd1\xcfI\xfa\xe9.i\xb26\xbe\xaa08\xd2\xa4S\xac\xf3\xb6\xf5\xdb\xf8?\x1a\xd2\x87@6\x06\xda\x8dVjV\xcc\xfbFT\xb3\x08\x89\x9c%27\x10*\xd2c\xc7\xf4`\xd3\x1e\xd3$C\x89\x96\xa4o\xd2u\xca\xba\x93\xcf\x99\x96U\x01\xc9k\xcb/\xfc\xcf\xeb\xb7o\xa01I\x1eH\xe6\xdb\x8e4.\xce\x10\xfcT\x97\x19-&\x1d%\xd4\x94<11\x19\xc74\xdeaq\xb0\xd1\xf8;\xa4\xa7n\x8b\x8c;i\x9b\n\xcd5}\x8a\xde\xd2\xd9`\xe7\x1256\x1c\x08+\xf6\xa2\xb5\x162\x9c$\xf4h\xd2\xcc\xfb%\xc4\x02\xea<\xa1\x0f?;9\x89>\xbe\x7f\x85U\xd7^x\x89KH\'\xaeHx\x92fZtMB\xe7\xe0\x82\x06\x02M}[$<\x98yYO\x13:W\x17\x11DbB\xbdxQ\xa7\xfc\x01\xfa\xa2=\x8cO\x99\xda\xb4\xd9\xf2\x82\xe8&\xfb\'~\x90Z\xc5\xc4\xf4\xf4\x0b\x94&f\xcd/\x87\xb6xL\xdb8w\xaax\x91\x97+k\xf8\xa6\xa6\xfe\xeeOt\xbde7\xb95\x92\xb9\xc5:e\xf9,\xe9\xcb\x8e\x87\x90\xe5\xd0v2i\xf5\xf4oy\xda\x1d\xb4\xd4\x83\x8b\x9a\xc6Pu\xf1\x87\xf5*\xb7sf\xf07]\xceY\xd1P/\xdb\xbaoH\xef\xcb\xfbX\x95\x8a6\x1f\xb5\x12.\x80\xcd\x19M\x96N\x9b\xcc\x99\xf4\x15S\x1e\xd36#\xd5\xc1\xbb2\xeeX\x00\xe2\xdf"\x1a\x12\xaf\xf5"\xb9\xcd\xe9\xbc"]\xd2\xe8\xf6\xe4#\x1bM\xa6n\x02\xac9:\xddfY\x91\xcc\xdd\xd8\x03\xad%\xd3Ik\x90e\xa2\x99\x175\rA\xe6\x16\xef\xff\x9a\xdc\x06\xd6\x08\x8e\xe6\xe8y\x9a\xd6=I\xcd\xc04\xa1V\xf5\x99k\xd1\xaa\xf6\x18\x841x\xd0\x04\x93z\xdc\x16K\x9a\xf7D\x8d\x1f\xbf
,\xf0l%$b\x1e5\xa4\xb2I\xd3\xcf1\x890\xa0n\xeb"\xe3\x86zl\x82ID\x16D[\x1f{\x0bG\x8d\xa4\xe0\xbb\xc1N\xd2\x86q\xb6\x85MS+\xd7\x1brD\xef\xb7\xfb,\x89\x19\x9d\x19E\xc9\xfa\xf9\xe7>\xfd\x94w\xb0\xf0j\xacN\xd4\xa6M\x81\x8d\xb1\xb1$x\xf8\x85Z\x88l\x86\x89@T\t}2"\r\x8a\xbfqo\x0eN\x0e
\x1c\x1b\xab"\xf6$\x0f\x97\xbaK\xb2CJn\t\x9dB\x0f\xf3y\x98I\xdf\n\x92\x93\x8e\xcd\x0e\xb1\xf7\xba\xb1z#Ymk\xb1\x86\x9ae\x147b\xaa,WeA\xef\xf0_\x12\xa8l\xea5\xcb\x00M\x95\xf6U\xf5\x0c=D\xa65\xfd\xe7m^\xae\xf9P
\x9b\xcd\xef_\xffUS\x01K\x15\xd4\x88\x15\x0bu\x12\xfbA\xferH\xd6\xd5\x02\n\x08\xd6.}z\x86g`A\xa5G^\x04\xd4BK\xb0u\xe2\xdf\xf3\xa6\x86!\xd2\x89\xc5V\xf0^k\xe4\xfcJ*\x9c\xf5j\xa6\xb7f\xa7\xb…
(message too large)

[Raphael Kubo da Costa (rakuco), 2014-12-17 16:39:45]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2014-12-17 16:39:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809053002/40001

[commit-bot: I haz the power, 2014-12-17 16:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 16:42:53]

Presubmit check for 809053002-40001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (113 files) (125.25s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:41: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module android
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module blink
W: 13, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module ios
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module presubmit_unittest
E:2003, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2003, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2003, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2020, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2020, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2020, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2377, 4: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2396, 4: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2636, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)


Presubmit checks took 169.2s to calculate.

[Raphael Kubo da Costa (rakuco), 2014-12-17 16:57:00]

The pylint errors above are all unrelated to this patch. What should I do?

[Primiano Tucci (use gerrit), 2014-12-17 17:00:22]

It seems a case for NOTRY=true. Infra folks?

On Wed, Dec 17, 2014 at 4:57 PM, <raphael.kubo.da.costa@intel.com> wrote:
>
> The pylint errors above are all unrelated to this patch. What should I do?
>
> https://codereview.chromium.org/809053002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[pgervais, 2014-12-17 17:22:50]

Yes, all these errors are probably caused by the recent switch to a new
pylint.
You can use NOTRY here, but please add a message explaining why you did
that.

However, these presubmit errors have to be fixed. Could you also file an
issue to track work on it and CC me, maruel@ and iannucci@ (at least)?

Thanks


On Wed, Dec 17, 2014 at 9:00 AM, Primiano Tucci <primiano@chromium.org>
wrote:
>
> It seems a case for NOTRY=true. Infra folks?
>
> On Wed, Dec 17, 2014 at 4:57 PM, <raphael.kubo.da.costa@intel.com> wrote:
>>
>> The pylint errors above are all unrelated to this patch. What should I do?
>>
>> https://codereview.chromium.org/809053002/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Raphael Kubo da Costa (rakuco), 2014-12-17 17:35:36]

On 2014/12/17 17:22:50, pgervais wrote:
> However, these presubmit errors have to be fixed. Could you also file an
> issue to track work on it and CC me, maruel@ and iannucci@ (at least)?

Done: https://code.google.com/p/chromium/issues/detail?id=443232

[Raphael Kubo da Costa (rakuco), 2014-12-17 17:36:03]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2014-12-17 17:37:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809053002/40001

[commit-bot: I haz the power, 2014-12-17 17:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 17:39:59]

Presubmit check for 809053002-40001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (113 files) (126.22s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:41: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module android
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module blink
W: 13, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module ios
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module presubmit_unittest
E:2003, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2003, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2003, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2020, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2020, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2020, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2377, 4: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2396, 4: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2636, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)


Presubmit checks took 164.6s to calculate.

[Raphael Kubo da Costa (rakuco), 2014-12-17 17:44:36]

Hmm, shouldn't it be enough to set "NOTRY=true" in the description here?

[pgervais, 2014-12-17 18:02:42]

On 2014/12/17 17:44:36, Raphael Kubo da Costa (rakuco) wrote:
> Hmm, shouldn't it be enough to set "NOTRY=true" in the description here?

I missed that. The tests are failing inside presubmit, which is not run as a try
job.
I'm not sure there is a way to bypass just these tests. Try adding
NOTREECHECKS=true.

[Primiano Tucci (use gerrit), 2014-12-18 11:12:38]

Committed patchset #3 (id:40001) manually as 293439.

[Primiano Tucci (use gerrit), 2014-12-18 11:13:02]

On 2014/12/18 11:12:38, Primiano Tucci wrote:
> Committed patchset #3 (id:40001) manually as 293439.

Landed this manually.