Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809023003: Oilpan: fix build after r187362. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r187362. R=yurys BUG=439376 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187368

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +2 lines, -1 line 1 comment Download
M Source/core/inspector/WorkerDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look.
6 years ago (2014-12-17 11:48:38 UTC) #1
yurys
lgtm
6 years ago (2014-12-17 12:04:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809023003/1
6 years ago (2014-12-17 12:12:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187368
6 years ago (2014-12-17 12:26:20 UTC) #6
haraken
6 years ago (2014-12-17 14:34:44 UTC) #8
Message was sent while issue was closed. 
LGTM

https://codereview.chromium.org/809023003/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorDebuggerAgent.cpp (right):

https://codereview.chromium.org/809023003/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorDebuggerAgent.cpp:1566: #if ENABLE(OILPAN)

kouhei@: BTW, we can now remove #if ENABLE(OILPAN) from all trace methods,
right?

Powered by Google App Engine
This is Rietveld 408576698