Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 809003002: x86: enable check of Atom (Closed)

Created:
6 years ago by Weiliang
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

x86: enable check of Atom BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M src/base/cpu.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/base/cpu.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Weiliang
PTAL
6 years ago (2014-12-17 08:38:05 UTC) #2
Benedikt Meurer
6 years ago (2014-12-19 06:35:19 UTC) #3
I'm still not convinced that we need this ATOM flag at all. We should generate
code that runs fast on Core processors and good/acceptable on Atom, and only if
there's an extremely important corner case that cannot be optimized in general,
fall back to special code path for Atom.

Powered by Google App Engine
This is Rietveld 408576698