Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 808973004: GVDA, vdatest: Enable V4L2SliceVideoDecodeAccelerator. (Closed)

Created:
5 years, 11 months ago by Pawel Osciak
Modified:
5 years, 11 months ago
Reviewers:
kcwu, wuchengli, henryhsu
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@vp8_slice_based
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GVDA, vdatest: Enable V4L2SliceVideoDecodeAccelerator. Instantiate V4L2SVDA in GVDA and vdatest to be used if the hardware cannot support the current frame-based API and try to use slice-based API instead. BUG=chrome-os-partner:33728 TEST=vdatest,veatest,apprtc,video playback Committed: https://crrev.com/daa138be4bc9374516fa0f779cc5e5fb8c38fbe4 Cr-Commit-Position: refs/heads/master@{#311465}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 4 chunks +24 lines, -1 line 1 comment Download

Messages

Total messages: 12 (4 generated)
Pawel Osciak
ptal
5 years, 11 months ago (2015-01-12 03:36:25 UTC) #2
Pawel Osciak
ptal
5 years, 11 months ago (2015-01-12 03:36:25 UTC) #3
wuchengli
LGTM. https://codereview.chromium.org/808973004/diff/1/content/common/gpu/media/video_decode_accelerator_unittest.cc File content/common/gpu/media/video_decode_accelerator_unittest.cc (right): https://codereview.chromium.org/808973004/diff/1/content/common/gpu/media/video_decode_accelerator_unittest.cc#newcode461 content/common/gpu/media/video_decode_accelerator_unittest.cc:461: GLRenderingVDAClient::CreateV4L2SliceVDA() { We have more duplication like this ...
5 years, 11 months ago (2015-01-12 06:05:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808973004/1
5 years, 11 months ago (2015-01-14 10:50:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808973004/1
5 years, 11 months ago (2015-01-14 13:00:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 13:00:53 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/daa138be4bc9374516fa0f779cc5e5fb8c38fbe4 Cr-Commit-Position: refs/heads/master@{#311465}
5 years, 11 months ago (2015-01-14 13:02:57 UTC) #11
Ken Rockot(use gerrit already)
5 years, 11 months ago (2015-01-14 22:50:07 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/848233002/ by rockot@chromium.org.

The reason for reverting is: Dependent on
https://codereview.chromium.org/852103002/ which was reverted due to arm
breakage.

Powered by Google App Engine
This is Rietveld 408576698