Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: tools/telemetry/telemetry/user_story/user_story_set_unittest.py

Issue 808893002: [Telemetry] Remove session_restore's use of PageTest.CanRunForPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unittest Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_set.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/user_story/user_story_set_unittest.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_set_unittest.py b/tools/telemetry/telemetry/user_story/user_story_set_unittest.py
index be7d10380f16e20ac85f1655c4f296910948f42c..9b381d6c7975088bc5df6391eaa0f7f7c0360f3a 100644
--- a/tools/telemetry/telemetry/user_story/user_story_set_unittest.py
+++ b/tools/telemetry/telemetry/user_story/user_story_set_unittest.py
@@ -5,10 +5,23 @@
import os
import unittest
+from telemetry import user_story
+from telemetry.user_story import shared_user_story_state
from telemetry.user_story import user_story_set
from telemetry.util import cloud_storage
+# pylint: disable=abstract-method
+class SharedUserStoryStateBar(shared_user_story_state.SharedUserStoryState):
+ pass
+
+
+class UserStoryFoo(user_story.UserStory):
+ def __init__(self, name='', labels=None):
+ super(UserStoryFoo, self).__init__(
+ SharedUserStoryStateBar, name, labels)
+
+
class UserStorySetFoo(user_story_set.UserStorySet):
""" UserStorySetFoo is a user story created for testing purpose. """
pass
@@ -46,5 +59,20 @@ class UserStorySetTest(unittest.TestCase):
cloud_storage_bucket=cloud_storage.INTERNAL_BUCKET)
self.assertEqual(internal_uss.bucket, cloud_storage.INTERNAL_BUCKET)
- self.assertRaises(ValueError, user_story_set.UserStorySet,
- cloud_storage_bucket='garbage_bucket')
+ with self.assertRaises(ValueError):
+ user_story_set.UserStorySet(cloud_storage_bucket='garbage_bucket')
+
+ def testRemoveWithEmptySetRaises(self):
+ uss = user_story_set.UserStorySet()
+ foo_story = UserStoryFoo()
+ with self.assertRaises(ValueError):
+ uss.RemoveUserStory(foo_story)
+
+ def testBasicAddRemove(self):
+ uss = user_story_set.UserStorySet()
+ foo_story = UserStoryFoo()
+ uss.AddUserStory(foo_story)
+ self.assertEqual([foo_story], uss.user_stories)
+
+ uss.RemoveUserStory(foo_story)
+ self.assertEqual([], uss.user_stories)
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_set.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698