tools/perf/measurements/session_restore.py - Issue 808893002: [Telemetry] Remove session_restore's use of PageTest.CanRunForPage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/session_restore.py

Issue 808893002: [Telemetry] Remove session_restore's use of PageTest.CanRunForPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unittest Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/session_restore.py

diff --git a/tools/perf/measurements/session_restore.py b/tools/perf/measurements/session_restore.py

index 06e570c36309b30e77f0db30755547d90db1fef7..6c35a1d5822ad3130eb078462839be5b934a7175 100644

--- a/tools/perf/measurements/session_restore.py

+++ b/tools/perf/measurements/session_restore.py

@@ -42,12 +42,8 @@ class SessionRestore(startup.Startup):

60)

return browser.foreground_tab

- def CanRunForPage(self, page):

- # No matter how many pages in the pageset, just perform one test iteration.

- return page.page_set.pages.index(page) == 0

def RunNavigateSteps(self, page, tab):

- # Overriden so that no page navigation occurs.

+ # Overridden so that no page navigation occurs.

pass

def ValidatePageSet(self, page_set):

« no previous file with comments | « tools/perf/benchmarks/session_restore.py ('k') | tools/telemetry/telemetry/user_story/user_story_set.py » ('j') | no next file with comments »