Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: tools/telemetry/telemetry/user_story/user_story_set.py

Issue 808893002: [Telemetry] Remove session_restore's use of PageTest.CanRunForPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add UserStorySet.RemoveUserStory Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/user_story/user_story_set.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_set.py b/tools/telemetry/telemetry/user_story/user_story_set.py
index b4315ffc9e7799afe216fa37bcf115909d0daace..0d77187d260e24d5108ca5fb6e3469d3983b6a87 100644
--- a/tools/telemetry/telemetry/user_story/user_story_set.py
+++ b/tools/telemetry/telemetry/user_story/user_story_set.py
@@ -70,6 +70,13 @@ class UserStorySet(object):
assert isinstance(user_story, user_story_module.UserStory)
self.user_stories.append(user_story)
+ def RemoveUserStory(self, user_story):
+ """Remove a user story.
qyearsley 2015/01/28 19:39:08 1. The verb in the docstring should be third-perso
slamm 2015/02/23 23:46:35 Done.
+
+ Allows the user stories to be filtered.
+ """
+ self.user_stories.remove(user_story)
+
@classmethod
def Name(cls):
""" Returns the string name of this UserStorySet.
qyearsley 2015/01/28 19:39:08 Outside the scope of this CL: There's an extra spa
slamm 2015/02/23 23:46:35 Done. These extra spaces are all over the place.
« tools/perf/benchmarks/session_restore.py ('K') | « tools/perf/benchmarks/session_restore.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698