Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1921)

Issue 808853006: Revert "Fixed StyledLabel size caching" (Closed)

Created:
6 years ago by oshima
Modified:
6 years ago
Reviewers:
edjomin, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fixed StyledLabel size caching" Reason for revert: UninitCondition in views::StyledLabel::SetDisplayedOnBackgroundColor see bug for more details. This reverts commit 1736bcf4e918f13c78ade1d446c7222c720d4d6a. > StyledLabel size caching was not really working due to width check > did not take control insets into account. So any call to > GetHeightForWidth or Layout caused full layout recalculation. > When view with StyledLabel is created CalculateAndDoLayout that > does all layouting job is called for five or six times with same > arguments. And each call caused StyledLabel reset and controls removal > R=sky@chromium.org > Review URL: https://codereview.chromium.org/734923003 BUG=443275 TBR=edjomin@yandex-team.ru, sky@chromium.org Committed: https://crrev.com/ae2f8670e66a882e8b00be8f217b377f53f0000d Cr-Commit-Position: refs/heads/master@{#308853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -67 lines) Patch
M ui/views/controls/styled_label.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/styled_label.cc View 4 chunks +9 lines, -22 lines 0 comments Download
M ui/views/controls/styled_label_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
oshima
6 years ago (2014-12-17 19:35:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808853006/1
6 years ago (2014-12-17 19:36:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-17 20:33:52 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-17 20:34:47 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae2f8670e66a882e8b00be8f217b377f53f0000d
Cr-Commit-Position: refs/heads/master@{#308853}

Powered by Google App Engine
This is Rietveld 408576698