Issue 808853003: [M40 merge] Detect discarded SkPictureShader pixel refs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808853003: [M40 merge] Detect discarded SkPictureShader pixel refs. (Closed)

Created:
6 years ago by f(malita)

Modified:
6 years ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@m40

Target Ref:
refs/heads/chrome/m40

Project:
skia

Visibility:
Public.

[M40 merge] Detect discarded SkPictureShader pixel refs. This doesn't address the more general problem, but reduces the race window significantly. (merge of 387a01a6357b4ba6ff87ac57626de1cb6a3b31bf) BUG=440282 TBR=reed@google.com NOTRY=true Committed: https://skia.googlesource.com/skia/+/413a1eb45e0210748f126edd9e0639b905394bb7

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/core/SkPictureShader.cpp	View		1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808853003/1

6 years ago (2014-12-16 22:56:00 UTC) #2

commit-bot: I haz the power

CLs for remote refs other than refs/heads/master must contain NOTRY=true in order for the CQ ...

6 years ago (2014-12-16 22:56:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808853003/1

6 years ago (2014-12-16 22:56:49 UTC) #6

commit-bot: I haz the power

6 years ago (2014-12-17 00:07:18 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/413a1eb45e0210748f126edd9e0639b905394bb7