Issue 808833003: Revert of [GN] Set v8_use_external_snapshot_data for the same configurations as GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808833003: Revert of [GN] Set v8_use_external_snapshot_data for the same configurations as GN. (Closed)

Created:
6 years ago by rmcilroy

Modified:
6 years ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of [GN] Set v8_use_external_snapshot_data for the same configurations as GN. (patchset #2 id:40001 of https://codereview.chromium.org/796903002/) Reason for revert: Revert for breaking Android GN bot Original issue's description: > [GN] Set v8_use_external_snapshot_data for the same configurations as GN. > > BUG=421063 > > Committed: https://crrev.com/def2eb00493259ff297e8792fee35dc7dc2204b5 > Cr-Commit-Position: refs/heads/master@{#308779} TBR=brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=421063 Committed: https://crrev.com/eb0f9c17e6e007246cac5c55db217df8fd290f64 Cr-Commit-Position: refs/heads/master@{#308781}

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	build/module_args/v8.gni	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	net/BUILD.gn	View		2 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

rmcilroy

Created Revert of [GN] Set v8_use_external_snapshot_data for the same configurations as GN.

6 years ago (2014-12-17 12:09:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808833003/1

6 years ago (2014-12-17 12:10:35 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-17 12:11:47 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eb0f9c17e6e007246cac5c55db217df8fd290f64
Cr-Commit-Position: refs/heads/master@{#308781}