Allocate GCInfo descriptor table during Oilpan initialization.

Allocate GCInfo descriptor table during Oilpan initialization.

Dynamically allocate this block of GCInfo object descriptors.

R=haraken
BUG=420515
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187906

[sof, 2015-01-06 07:43:16]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-01-06 07:43:17]

Please take a look.

I will verify perf before & after.

[haraken, 2015-01-06 08:08:03]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-01-06 08:08:04]

LGTM, thanks!

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Heap.cpp
File Source/platform/heap/Heap.cpp (right):

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Heap.cp...
Source/platform/heap/Heap.cpp:1987: s_gcInfoTable = reinterpret_cast<GCInfo
const**>(new uint8_t[tableSize]);

Can we add 'delete' code to doShutdown()?

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Heap.h
File Source/platform/heap/Heap.h (right):

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Heap.h#...
Source/platform/heap/Heap.h:937: const GCInfo* info =
s_gcInfoTable[gcInfoIndex];

Add ASSERT(s_gcInfoTable)

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Visitor...
File Source/platform/heap/Visitor.cpp (right):

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Visitor...
Source/platform/heap/Visitor.cpp:44: GCInfo const** s_gcInfoTable = 0;

0 => nullptr

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Visitor.h
File Source/platform/heap/Visitor.h (right):

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Visitor...
Source/platform/heap/Visitor.h:856: s_gcInfoTable[gcInfoIndex] = &gcInfo; \

Add ASSERT(s_gcInfoTable)

[sof, 2015-01-06 08:19:19]

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Heap.cpp
File Source/platform/heap/Heap.cpp (right):

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Heap.cp...
Source/platform/heap/Heap.cpp:1987: s_gcInfoTable = reinterpret_cast<GCInfo
const**>(new uint8_t[tableSize]);
On 2015/01/06 08:08:04, haraken wrote:
> 
> Can we add 'delete' code to doShutdown()?

Certainly, added.

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Heap.h
File Source/platform/heap/Heap.h (right):

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Heap.h#...
Source/platform/heap/Heap.h:937: const GCInfo* info =
s_gcInfoTable[gcInfoIndex];
On 2015/01/06 08:08:04, haraken wrote:
> 
> Add ASSERT(s_gcInfoTable)

Done.

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Visitor...
File Source/platform/heap/Visitor.cpp (right):

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Visitor...
Source/platform/heap/Visitor.cpp:44: GCInfo const** s_gcInfoTable = 0;
On 2015/01/06 08:08:04, haraken wrote:
> 
> 0 => nullptr

Done.

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Visitor.h
File Source/platform/heap/Visitor.h (right):

https://codereview.chromium.org/808803007/diff/1/Source/platform/heap/Visitor...
Source/platform/heap/Visitor.h:856: s_gcInfoTable[gcInfoIndex] = &gcInfo; \
On 2015/01/06 08:08:04, haraken wrote:
> 
> Add ASSERT(s_gcInfoTable)

Done.

[sof, 2015-01-06 08:45:14]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-01-06 08:45:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/808803007/40001

[commit-bot: I haz the power, 2015-01-06 09:57:22]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187906

[sof, 2015-01-06 19:13:20]

On 2015/01/06 07:43:17, sof wrote:
> Please take a look.
> 
> I will verify perf before & after.

blink_perf + dromaeo doesn't report anything unusual (modulo noise - double
checked the outliers as not reproducing),


https://docs.google.com/spreadsheets/d/1erKQeBGdGXO3y-Z0V4_Id1IX4bh1MqZldIzbi...