Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 808793005: Add numpad keys to ui::LocatedToNonLocatedKeyboardCode() (Closed)

Created:
5 years, 11 months ago by kpschoedel
Modified:
5 years, 11 months ago
Reviewers:
Wez
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@x444048-1-located
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add numpad keys to ui::LocatedToNonLocatedKeyboardCode() This will allow mojo, which uses located KeyboardCode values, to distinguish numpad digits from top-row digits. BUG=444048 R=wez@chromium.org Committed: https://crrev.com/d6c48bf84a17a6f521a82b77e0b8c49fe5b9730c Cr-Commit-Position: refs/heads/master@{#311413}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M ui/events/keycodes/keyboard_code_conversion.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kpschoedel
Dependent on https://codereview.chromium.org/796003005/
5 years, 11 months ago (2015-01-12 16:34:58 UTC) #1
Wez
LGTM Worth noting in the CL description that this (presumably) fixes numeric pad keys to ...
5 years, 11 months ago (2015-01-13 03:10:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808793005/20001
5 years, 11 months ago (2015-01-13 23:33:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/23051)
5 years, 11 months ago (2015-01-14 01:34:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808793005/20001
5 years, 11 months ago (2015-01-14 05:02:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 05:31:10 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 05:31:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6c48bf84a17a6f521a82b77e0b8c49fe5b9730c
Cr-Commit-Position: refs/heads/master@{#311413}

Powered by Google App Engine
This is Rietveld 408576698