Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 808783003: Revert of Enable dark_resume_always workaround if the wake-on-packets flag is set (Closed)

Created:
6 years ago by Chirantan Ekbote
Modified:
6 years ago
Reviewers:
stevenjb, Daniel Erat
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, Sameer Nanda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable dark_resume_always workaround if the wake-on-packets flag is set (patchset #4 id:60001 of https://codereview.chromium.org/589723003/) Reason for revert: Kernel changes have landed. This workaround is no longer needed. Original issue's description: > Enable dark_resume_always workaround if the wake-on-packets flag is set > > The dark_resume_always workaround is necessary for testing > wake-on-packets functionality because the mechanism to actually query > the wakeup source is not ready yet. This workaround tells the kernel to > always enter dark resume and rely on chrome and powerd to detect user > activity and transition into fully resumed. > > BUG=414949 > > Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>; > > Committed: https://crrev.com/2faeee1528f5ebc1cec10aba595fdd100366aba0 > Cr-Commit-Position: refs/heads/master@{#296082} TBR=derat@chromium.org,stevenjb@chromium.org NOTREECHECKS=true NOTRY=true BUG=414949 Committed: https://crrev.com/29144cf051066ab045e49b15812594c7f7603aaf Cr-Commit-Position: refs/heads/master@{#309299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/browser/chromeos/power/light_bar.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Chirantan Ekbote
Created Revert of Enable dark_resume_always workaround if the wake-on-packets flag is set
6 years ago (2014-12-19 23:41:12 UTC) #1
Daniel Erat
lgtm
6 years ago (2014-12-19 23:43:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808783003/1
6 years ago (2014-12-19 23:44:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 23:46:01 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-19 23:46:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29144cf051066ab045e49b15812594c7f7603aaf
Cr-Commit-Position: refs/heads/master@{#309299}

Powered by Google App Engine
This is Rietveld 408576698