Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 808753006: Add back i18n-values=.*font{Family,fontSize} for now (Closed)

Created:
5 years, 11 months ago by jungshik at Google
Modified:
5 years, 11 months ago
Reviewers:
xdai1, Evan Stade
CC:
chromium-reviews, Dan Beam, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add back i18n-values=.*font{Family,fontSize} for now Interstitial pages are loaded via data url and cannot access chrome://text_default.css. Until the way they're loaded is changed, we have to use the old way. While I'm at it, I made supervised_user_block_interstitial.html use IDS_WEB_FONT_FAMILY instead of the hard-coded fonts in the corresponding css. This change is for bug 303849. BUG=443203, 303849 TEST=See comment 4 in the bug 443203. See also http://crbug.com/444698 Committed: https://crrev.com/b5a98d7cfad4b842f83a22895ab4449fa50e06b0 Cr-Commit-Position: refs/heads/master@{#310142}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add me to TODO #

Patch Set 3 : add a full stop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/resources/security_warnings/interstitial_v2.html View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/supervised_user_block_interstitial.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/supervised_user_block_interstitial.html View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jungshik at Google
Can you take a look? Thanks
5 years, 11 months ago (2015-01-05 23:50:04 UTC) #3
xdai1
lgtm
5 years, 11 months ago (2015-01-06 01:54:31 UTC) #4
Evan Stade
lgtm https://codereview.chromium.org/808753006/diff/1/chrome/browser/resources/security_warnings/interstitial_v2.html File chrome/browser/resources/security_warnings/interstitial_v2.html (right): https://codereview.chromium.org/808753006/diff/1/chrome/browser/resources/security_warnings/interstitial_v2.html#newcode14 chrome/browser/resources/security_warnings/interstitial_v2.html:14: <!-- TODO: Get rid of i18n-values and import ...
5 years, 11 months ago (2015-01-06 18:32:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808753006/40001
5 years, 11 months ago (2015-01-06 19:57:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-06 21:01:05 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 21:02:51 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b5a98d7cfad4b842f83a22895ab4449fa50e06b0
Cr-Commit-Position: refs/heads/master@{#310142}

Powered by Google App Engine
This is Rietveld 408576698