Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 808743004: Revert of Re-land: base: Enable browser-wide discardable memory on Linux, CrOS and Windows. (Closed)

Created:
5 years, 11 months ago by reveman
Modified:
5 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@free-list
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land: base: Enable browser-wide discardable memory on Linux, CrOS and Windows. (patchset #1 id:1 of https://codereview.chromium.org/793443003/) Reason for revert: Need to fix these issues before reland: crbug.com/450096 crbug.com/450122 crbug.com/449907 Original issue's description: > Re-land: base: Enable browser-wide discardable memory on Linux, CrOS and Windows. > > This makes SHMEM implementation of discardable memory preferred > over EMULATED implementation. This effectively makes SHMEM the > implementation used by default on Linux, CrOS and Windows. > > SHMEM implementation of discardable memory gives the browser > process control over the total amount of discardable memory used > and allows us to enforce a global limit of 512MB across all > renderers. > > BUG=429415, 429416 > > Committed: https://crrev.com/07e0fd329293cca145875e156b87afdf383dcdc0 > Cr-Commit-Position: refs/heads/master@{#312045} TBR=avi@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429415, 429416 Committed: https://crrev.com/1374d88a7d60d1ad80adcfd038ca4a9b83d0c627 Cr-Commit-Position: refs/heads/master@{#312214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M base/memory/discardable_memory_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/discardable_memory_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reveman
Created Revert of Re-land: base: Enable browser-wide discardable memory on Linux, CrOS and Windows.
5 years, 11 months ago (2015-01-20 17:12:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808743004/1
5 years, 11 months ago (2015-01-20 17:13:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 17:14:27 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 17:15:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1374d88a7d60d1ad80adcfd038ca4a9b83d0c627
Cr-Commit-Position: refs/heads/master@{#312214}

Powered by Google App Engine
This is Rietveld 408576698