Issue 808663002: Revert "Add POST support to XHR as well as .status and statusText support"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808663002: Revert "Add POST support to XHR as well as .status and statusText support" (Closed)

Created:
6 years ago by eseidel

Modified:
6 years ago

Reviewers:
esprehn

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert "Add POST support to XHR as well as .status and statusText support" This reverts commit 5ef81d249b841f44c9593ffb0158d64c7e0febfc. This appeared to make 5 XHR tests timeout. Not sure why yet. TBR=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3331c07f7d8c00581677e0f7f1459950d1e43a6c

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -113 lines)			Patch
M	sky/framework/xmlhttprequest.sky	View	3 chunks	+3 lines, -44 lines	0 comments	Download
M	sky/tests/framework/xmlhttprequest/empty-responseType.sky	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/tests/framework/xmlhttprequest/responseType.sky	View	1 chunk	+4 lines, -3 lines	0 comments	Download
D	sky/tests/framework/xmlhttprequest/unicode-post.sky	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	sky/tests/framework/xmlhttprequest/unicode-post-expected.txt	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/tests/framework/xmlhttprequest/xhr.sky	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	sky/tests/framework/xmlhttprequest/xhr-does-not-exist.sky	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	sky/tests/framework/xmlhttprequest/xhr-does-not-exist-expected.txt	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/tests/framework/xmlhttprequest/xhr-relative.sky	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/tools/skygo/sky_server.go	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	sky/tools/skygo/sky_server.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

eseidel

6 years ago (2014-12-16 02:37:49 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3331c07f7d8c00581677e0f7f1459950d1e43a6c (presubmit successful).