Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 808633002: Fix MediaTypeConvertersTest. (Closed)

Created:
6 years ago by xhwang
Modified:
6 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MediaTypeConvertersTest. Currently we are not serializing the data of a DecoderBuffer. The data will be serialized into a separate DataPipe. Therefore, drop the data check in MediaTypeConvertersTest. See r307328 for details. BUG=392236 TEST=This CL fixing failing tests. Committed: https://crrev.com/9904df6a644142a272b56965eed886694d8c983a Cr-Commit-Position: refs/heads/master@{#308482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M media/mojo/services/media_type_converters_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
xhwang
PTAL Also, we should enable these tests so that a GN build will run them ...
6 years ago (2014-12-15 22:59:48 UTC) #2
xhwang
PTAL Also, we should enable these tests so that a GN build will run them ...
6 years ago (2014-12-15 22:59:49 UTC) #3
DaleCurtis
The gn bots don't run any tests yet, so I don't think there's anything we ...
6 years ago (2014-12-15 23:05:20 UTC) #4
xhwang
On 2014/12/15 23:05:20, DaleCurtis wrote: > The gn bots don't run any tests yet, so ...
6 years ago (2014-12-15 23:15:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808633002/1
6 years ago (2014-12-15 23:17:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 00:56:43 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-16 00:57:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9904df6a644142a272b56965eed886694d8c983a
Cr-Commit-Position: refs/heads/master@{#308482}

Powered by Google App Engine
This is Rietveld 408576698