win: Get client/crashpad_info.cc to compile

win: Get client/crashpad_info.cc to compile

Just avoid the Mac-specific __attribute__ tagging for now. There will need
to be some Windows-specific pragmas added here once the reader has been
written.

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b0cf01978d0d64bee4bcb4c1a97444cd3410713b

[Mark Mentovai, 2014-12-15 23:38:34]

https://codereview.chromium.org/808623002/diff/1/client/crashpad_info.cc
File client/crashpad_info.cc (right):

https://codereview.chromium.org/808623002/diff/1/client/crashpad_info.cc#newc...
client/crashpad_info.cc:19: #if defined(OS_MAC)
#include "build/build_config.h" to use this.

The correct macro is OS_MACOSX, not OS_MAC. Also below.

https://codereview.chromium.org/808623002/diff/1/client/crashpad_info.cc#newc...
client/crashpad_info.cc:54: // Put the structure in __DATA,__crashpad_info where
it can be easily found
Aside from the actual section name, this comment’s not Mac-specific at all, and
doesn’t belong inside the #ifdef.

[scottmg, 2014-12-16 00:03:05]

Patchset #2 (id:20001) has been deleted

[scottmg, 2014-12-16 00:13:19]

Patchset #2 (id:40001) has been deleted

[scottmg, 2014-12-16 00:18:08]

https://codereview.chromium.org/808623002/diff/1/client/crashpad_info.cc
File client/crashpad_info.cc (right):

https://codereview.chromium.org/808623002/diff/1/client/crashpad_info.cc#newc...
client/crashpad_info.cc:19: #if defined(OS_MAC)
On 2014/12/15 23:38:34, Mark Mentovai wrote:
> #include "build/build_config.h" to use this.

Done. I'm unclear on the guidance for this. It must be directly included by this
file or its header? But base/basictypes.h being known to include it is
insufficient?

> The correct macro is OS_MACOSX, not OS_MAC. Also below.

Oof. Done.

https://codereview.chromium.org/808623002/diff/1/client/crashpad_info.cc#newc...
client/crashpad_info.cc:54: // Put the structure in __DATA,__crashpad_info where
it can be easily found
On 2014/12/15 23:38:34, Mark Mentovai wrote:
> Aside from the actual section name, this comment’s not Mac-specific at all,
and
> doesn’t belong inside the #ifdef.

Improved.

I removed the Windows pragmas for now as without testing them and writing the
thing that reads them they're not much use anyway.

[Mark Mentovai, 2014-12-16 14:14:15]

LGTM

https://codereview.chromium.org/808623002/diff/1/client/crashpad_info.cc
File client/crashpad_info.cc (right):

https://codereview.chromium.org/808623002/diff/1/client/crashpad_info.cc#newc...
client/crashpad_info.cc:19: #if defined(OS_MAC)
scottmg wrote:
> On 2014/12/15 23:38:34, Mark Mentovai wrote:
> > #include "build/build_config.h" to use this.
> 
> Done. I'm unclear on the guidance for this. It must be directly included by
this
> file or its header? But base/basictypes.h being known to include it is
> insufficient?

That’s right. We’re following “include what you use” strictly here.

In Chrome, it’s typically considered OK to rely on build/build_config.h being
available as a side effect of base/basictypes.h being included. In Crashpad, I’m
trying to be more explicit about things.

In fact, in today’s mini_chromium, there’s no reason that base/basictypes.h even
needs to include build/build_config.h at all.

https://codereview.chromium.org/808623002/diff/100001/client/crashpad_info.cc
File client/crashpad_info.cc (right):

https://codereview.chromium.org/808623002/diff/100001/client/crashpad_info.cc...
client/crashpad_info.cc:51: // This structure needs to be stored somewhere that
is easy-to-find without
No hyphens in “easy to find.”

https://codereview.chromium.org/808623002/diff/100001/client/crashpad_info.cc...
client/crashpad_info.cc:74: // TODO(scottmg): Tag in a way that makes it easy to
locate on Windows.
The #pragmas are gone, so update the change description.

[scottmg, 2014-12-16 18:11:50]

https://codereview.chromium.org/808623002/diff/100001/client/crashpad_info.cc
File client/crashpad_info.cc (right):

https://codereview.chromium.org/808623002/diff/100001/client/crashpad_info.cc...
client/crashpad_info.cc:51: // This structure needs to be stored somewhere that
is easy-to-find without
On 2014/12/16 14:14:14, Mark Mentovai wrote:
> No hyphens in “easy to find.”

Done.

https://codereview.chromium.org/808623002/diff/100001/client/crashpad_info.cc...
client/crashpad_info.cc:74: // TODO(scottmg): Tag in a way that makes it easy to
locate on Windows.
On 2014/12/16 14:14:14, Mark Mentovai wrote:
> The #pragmas are gone, so update the change description.

Done.

[scottmg, 2014-12-16 18:22:47]

Committed patchset #5 (id:110001) manually as
b0cf01978d0d64bee4bcb4c1a97444cd3410713b (presubmit successful).