Make devtools use common generated blink source directory instead of gen/webkit.

Make devtools use common generated blink source directory instead of gen/webkit.

This is the last place which refers to out/(Release|Debug)/gen/webkit directory for the
generated resources to reside. The CL migrates this generation to use gen/blink directory
for this.

Committed: https://crrev.com/77816a11e50395fb5454677c6ce6eef3e1fa4b9f
Cr-Commit-Position: refs/heads/master@{#309006}

[vivekg, 2014-12-17 12:09:06]

vivekg@chromium.org changed reviewers:
+ jochen@chromium.org

[vivekg, 2014-12-17 13:19:32]

vivekg@chromium.org changed reviewers:
+ scheib@chromium.org, thakis@chromium.org

[vivekg, 2014-12-17 13:24:11]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2014-12-17 13:24:12]

PTAL, thank you.

@pfeldman: content/browser/devtools/devtools_resources.gyp
@jochen: content/*, chrome/*
@scheib: extensions/*
@thakis: build/get_landmines.py

[scheib, 2014-12-17 17:01:41]

extensions/* lgtm

[Nico, 2014-12-17 19:27:50]

Why is the landmine needed? Does anything still add gen/webkit to include_dirs?

[vivekg, 2014-12-17 20:26:27]

On 2014/12/17 19:27:50, Nico wrote:
> Why is the landmine needed? Does anything still add gen/webkit to
include_dirs?

On a previous occasion, similar changes caused lot of tree redness post commit.
So to be sure that this doesn't cause the same, I added the landmine.

[Nico, 2014-12-17 20:27:36]

On 2014/12/17 20:26:27, vivekg_ wrote:
> On 2014/12/17 19:27:50, Nico wrote:
> > Why is the landmine needed? Does anything still add gen/webkit to
> include_dirs?
> 
> On a previous occasion, similar changes caused lot of tree redness post
commit.
> So to be sure that this doesn't cause the same, I added the landmine.

Right, but the CL description says "This is the last place which referts to
gen/webkit", so if we remove all references to it from gyp files we should be
good?

[vivekg, 2014-12-17 20:33:23]

On 2014/12/17 20:27:36, Nico wrote:
> 
> Right, but the CL description says "This is the last place which referts to
> gen/webkit", so if we remove all references to it from gyp files we should be
> good?

Sure makes sense :) 

In that case, this would be the same as patch set 2. I will remove the landmine
and re-upload. Thank you.

[Nico, 2014-12-17 20:39:53]

Do you need to remove
https://code.google.com/p/chromium/codesearch#chromium/src/components/compone...
too btw?

[vivekg, 2014-12-17 20:55:47]

On 2014/12/17 at 20:39:53, thakis wrote:
> Do you need to remove
https://code.google.com/p/chromium/codesearch#chromium/src/components/compone...
too btw?

Oh yeah, missed that as its on windows. Thanks for pointing out. Corrected it
and uploaded a new version without the landmine. PTAL.

[vivekg, 2014-12-18 08:47:30]

@pfeldman, WDYT?

[jochen (gone - plz use gerrit), 2014-12-18 12:41:18]

lgtm

[pfeldman, 2014-12-18 14:12:42]

lgtm

[vivekg, 2014-12-18 14:17:26]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-12-18 14:18:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/808573003/50012

[commit-bot: I haz the power, 2014-12-18 14:28:28]

Committed patchset #4 (id:50012)

[commit-bot: I haz the power, 2014-12-18 14:29:25]

Patchset 4 (id:??) landed as
https://crrev.com/77816a11e50395fb5454677c6ce6eef3e1fa4b9f
Cr-Commit-Position: refs/heads/master@{#309006}