Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: chrome/browser/chromeos/login/session/user_session_manager.cc

Issue 808563004: Clean up Smart Lock cryptohome keys logic: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/session/user_session_manager.cc
diff --git a/chrome/browser/chromeos/login/session/user_session_manager.cc b/chrome/browser/chromeos/login/session/user_session_manager.cc
index 98ac1177d6157950e5794d314f02924a06a7d6b7..c9abbfbf612be6813adf288985b58422bb127ee0 100644
--- a/chrome/browser/chromeos/login/session/user_session_manager.cc
+++ b/chrome/browser/chromeos/login/session/user_session_manager.cc
@@ -1299,7 +1299,7 @@ void UserSessionManager::NotifyPendingUserSessionsRestoreFinished() {
void UserSessionManager::UpdateEasyUnlockKeys(const UserContext& user_context) {
// Skip key update because FakeCryptohomeClient always return success
- // and RemoveKey op expects a failure to stop. As a result, some tests would
+ // and RefreshKeys op expects a failure to stop. As a result, some tests would
// timeout.
// TODO(xiyuan): Revisit this when adding tests.
if (!base::SysInfo::IsRunningOnChromeOS())
@@ -1325,23 +1325,16 @@ void UserSessionManager::UpdateEasyUnlockKeys(const UserContext& user_context) {
EasyUnlockScreenlockStateHandler::NO_HARDLOCK);
}
+ base::ListValue empty_list;
+ if (!device_list)
+ device_list = &empty_list;
+
EasyUnlockKeyManager* key_manager = GetEasyUnlockKeyManager();
running_easy_unlock_key_ops_ = true;
- if (device_list) {
- key_manager->RefreshKeys(
- user_context,
- *device_list,
- base::Bind(&UserSessionManager::OnEasyUnlockKeyOpsFinished,
- AsWeakPtr(),
- user_context.GetUserID()));
- } else {
- key_manager->RemoveKeys(
- user_context,
- 0,
- base::Bind(&UserSessionManager::OnEasyUnlockKeyOpsFinished,
- AsWeakPtr(),
- user_context.GetUserID()));
- }
+ key_manager->RefreshKeys(
+ user_context, *device_list,
+ base::Bind(&UserSessionManager::OnEasyUnlockKeyOpsFinished, AsWeakPtr(),
+ user_context.GetUserID()));
}
void UserSessionManager::AttemptRestart(Profile* profile) {

Powered by Google App Engine
This is Rietveld 408576698