chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h - Issue 808563004: Clean up Smart Lock cryptohome keys logic:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h

Issue 808563004: Clean up Smart Lock cryptohome keys logic: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use UserContext after create keys operation Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h

diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h

index 856d0094b510d4ca78b5065825c505684347ecfc..8f8596beb5900484aabcab49e9068da41dd3a4cb 100644

--- a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h

+++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h

@@ -31,7 +31,9 @@ class EasyUnlockCreateKeysOperation {

void Start();

- const UserContext& user_context() const { return user_context_; }

+ // The UserContext returned will contain the new key if called after the

+ // operation has completed successfully.

+ const UserContext& user_context() { return user_context_; }

xiyuan 2014/12/17 21:02:42 nit: Can we put back "const"?

Tim Song 2014/12/17 21:45:23 Done.

private:

class ChallengeCreator;

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.h » ('j') | no next file with comments »