Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 808563003: Revert of Remove WindowFocusAllowedIndicator and associated code. (Closed)

Created:
6 years ago by amineer_google
Modified:
6 years ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, rwlbuis, serviceworker-reviews, sof, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@window_focus
Project:
blink
Visibility:
Public.

Description

Revert of Remove WindowFocusAllowedIndicator and associated code. (patchset #2 id:20001 of https://codereview.chromium.org/722423004/) Reason for revert: Crashing, see bug 441968 Original issue's description: > Remove WindowFocusAllowedIndicator and associated code. > > This is the last part of a three-sided CL: > Part 1: https://codereview.chromium.org/777483004/ > Part 2: https://codereview.chromium.org/786403003/ > Part 3: <this> > > BUG=440740 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187135 TBR=jochen@chromium.org,mkwst@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=440740 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -1 line) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/page/WindowFocusAllowedIndicator.h View 1 chunk +47 lines, -0 lines 0 comments Download
A Source/core/page/WindowFocusAllowedIndicator.cpp View 1 chunk +49 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebScopedWindowFocusAllowedIndicator.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/web/tests/WebScopedWindowFocusAllowedIndicatorTest.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M public/web/WebScopedWindowFocusAllowedIndicator.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
amineer_google
Created Revert of Remove WindowFocusAllowedIndicator and associated code.
6 years ago (2014-12-15 22:47:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808563003/1
6 years ago (2014-12-15 22:49:12 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-15 22:49:14 UTC) #4
Ken Rockot(use gerrit already)
On 2014/12/15 22:49:14, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years ago (2014-12-15 22:50:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808563003/1
6 years ago (2014-12-15 22:54:30 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 22:55:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187186

Powered by Google App Engine
This is Rietveld 408576698