Finish unit test for CFX_ByteStringC class.

Finish unit test for CFX_ByteStringC class.

This fixes a few cut-n-paste errors in the previous version, plus
adds more corner cases.  The implementation is fixed to handle a
few of these that failed.

R=brucedawson@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/310d26aadffd2f3141b683f40010109a455b403a

[Tom Sepez, 2015-01-06 18:09:48]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org, thestig@chromium.org

[Tom Sepez, 2015-01-06 18:10:08]

Lei, Bruce, please review.

[brucedawson, 2015-01-06 18:27:21]

lgtm

https://codereview.chromium.org/808553013/diff/40001/core/include/fxcrt/fx_st...
File core/include/fxcrt/fx_string.h (right):

https://codereview.chromium.org/808553013/diff/40001/core/include/fxcrt/fx_st...
core/include/fxcrt/fx_string.h:46: // TODO(tsepez): Mark single-argument string
constructors as explicit.
Perhaps put a comment above the class declaration to make it clear that this
class does not own memory -- it's closer to StringPiece than to std::string.
Right now you have to read a bunch of implementation to figure that out.

https://codereview.chromium.org/808553013/diff/40001/core/src/fxcrt/fx_basic_...
File core/src/fxcrt/fx_basic_bstring_unittest.cpp (right):

https://codereview.chromium.org/808553013/diff/40001/core/src/fxcrt/fx_basic_...
core/src/fxcrt/fx_basic_bstring_unittest.cpp:38: assigned_nullptr_string =
(FX_LPCSTR)0;
Better to use nullptr instead of 0 here?

[Tom Sepez, 2015-01-06 18:45:21]

https://codereview.chromium.org/808553013/diff/40001/core/include/fxcrt/fx_st...
File core/include/fxcrt/fx_string.h (right):

https://codereview.chromium.org/808553013/diff/40001/core/include/fxcrt/fx_st...
core/include/fxcrt/fx_string.h:46: // TODO(tsepez): Mark single-argument string
constructors as explicit.
On 2015/01/06 18:27:21, brucedawson wrote:
> Perhaps put a comment above the class declaration to make it clear that this
> class does not own memory -- it's closer to StringPiece than to std::string.
> Right now you have to read a bunch of implementation to figure that out.

Done. Much better.

https://codereview.chromium.org/808553013/diff/40001/core/src/fxcrt/fx_basic_...
File core/src/fxcrt/fx_basic_bstring_unittest.cpp (right):

https://codereview.chromium.org/808553013/diff/40001/core/src/fxcrt/fx_basic_...
core/src/fxcrt/fx_basic_bstring_unittest.cpp:38: assigned_nullptr_string =
(FX_LPCSTR)0;
On 2015/01/06 18:27:21, brucedawson wrote:
> Better to use nullptr instead of 0 here?

Done.

[Tom Sepez, 2015-01-07 20:31:44]

Committed patchset #4 (id:60001) manually as
310d26aadffd2f3141b683f40010109a455b403a (presubmit successful).