Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 808553007: Move HTMLViewer out of mojo namespace (Closed)

Created:
6 years ago by DaveMoore
Modified:
6 years ago
Reviewers:
jamesr
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move HTMLViewer et. al. out of mojo namespace BUG= Committed: https://crrev.com/1157ffee59acb5708e30e7ce7f2c0ea9e45943e8 Cr-Commit-Position: refs/heads/master@{#309110}

Patch Set 1 #

Patch Set 2 : git cl format result #

Patch Set 3 : Small cleanup #

Patch Set 4 : Put everything in html_viewer namespace #

Patch Set 5 : Put everything in html_viewer namespace #

Patch Set 6 : Fix ax_provider unittest #

Patch Set 7 : Fix merge mistake in test #

Patch Set 8 : Fix merge mistake in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -226 lines) Patch
M mojo/services/html_viewer/ax_provider_impl.h View 1 2 3 4 1 chunk +9 lines, -8 lines 0 comments Download
M mojo/services/html_viewer/ax_provider_impl.cc View 1 2 3 2 chunks +11 lines, -7 lines 0 comments Download
M mojo/services/html_viewer/ax_provider_impl_unittest.cc View 1 2 3 4 5 6 6 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/html_document.h View 1 2 3 4 4 chunks +34 lines, -30 lines 0 comments Download
M mojo/services/html_viewer/html_document.cc View 1 2 3 4 8 chunks +22 lines, -15 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 1 2 3 4 8 chunks +22 lines, -13 lines 0 comments Download
M mojo/services/html_viewer/mojo_blink_platform_impl.h View 1 2 3 4 2 chunks +7 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/mojo_blink_platform_impl.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/html_viewer/test_blink_platform_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/test_blink_platform_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/webclipboard_impl.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/webclipboard_impl.cc View 1 2 3 4 11 chunks +33 lines, -30 lines 0 comments Download
M mojo/services/html_viewer/webcookiejar_impl.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/webcookiejar_impl.cc View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 1 2 3 4 3 chunks +13 lines, -9 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.h View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.cc View 1 2 3 4 4 chunks +7 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/webmimeregistry_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/webmimeregistry_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/websockethandle_impl.h View 1 2 3 4 2 chunks +10 lines, -6 lines 0 comments Download
M mojo/services/html_viewer/websockethandle_impl.cc View 1 2 3 4 6 chunks +19 lines, -11 lines 0 comments Download
M mojo/services/html_viewer/webstoragenamespace_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/webstoragenamespace_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/webthemeengine_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/webthemeengine_impl.cc View 1 2 3 4 5 chunks +8 lines, -7 lines 0 comments Download
M mojo/services/html_viewer/webthread_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/webthread_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/weburlloader_impl.h View 1 2 3 4 3 chunks +12 lines, -9 lines 0 comments Download
M mojo/services/html_viewer/weburlloader_impl.cc View 1 2 3 4 5 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 24 (6 generated)
DaveMoore
git cl format result
6 years ago (2014-12-17 00:10:57 UTC) #1
DaveMoore
Small cleanup
6 years ago (2014-12-17 00:30:28 UTC) #2
DaveMoore
6 years ago (2014-12-17 00:31:42 UTC) #4
jamesr
I think these should still be in *a* namespace - symbols in the global namespace ...
6 years ago (2014-12-17 00:45:59 UTC) #5
DaveMoore
Put everything in html_viewer namespace
6 years ago (2014-12-17 16:00:01 UTC) #6
DaveMoore
Put everything in html_viewer namespace
6 years ago (2014-12-17 16:23:45 UTC) #7
DaveMoore
6 years ago (2014-12-17 16:30:18 UTC) #8
jamesr
lgtm
6 years ago (2014-12-17 18:34:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808553007/80001
6 years ago (2014-12-17 18:36:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/43740)
6 years ago (2014-12-17 18:54:55 UTC) #13
DaveMoore
Fix ax_provider unittest
6 years ago (2014-12-18 18:28:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808553007/100001
6 years ago (2014-12-18 18:31:35 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/44380)
6 years ago (2014-12-18 18:49:31 UTC) #18
DaveMoore
Fix merge mistake in test
6 years ago (2014-12-18 22:29:47 UTC) #19
DaveMoore
Fix merge mistake in test
6 years ago (2014-12-18 22:34:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808553007/140001
6 years ago (2014-12-18 22:35:23 UTC) #22
commit-bot: I haz the power
Committed patchset #8 (id:140001)
6 years ago (2014-12-19 00:10:07 UTC) #23
commit-bot: I haz the power
6 years ago (2014-12-19 00:11:41 UTC) #24
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/1157ffee59acb5708e30e7ce7f2c0ea9e45943e8
Cr-Commit-Position: refs/heads/master@{#309110}

Powered by Google App Engine
This is Rietveld 408576698