Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 808553004: Revert "cps-ir: Add support for intercepted calls." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library code_generator; 5 library code_generator;
6 6
7 import 'glue.dart'; 7 import 'glue.dart';
8 8
9 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir; 9 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
10 import '../../js/js.dart' as js; 10 import '../../js/js.dart' as js;
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 } 163 }
164 164
165 js.Expression compileConstant(ParameterElement parameter) { 165 js.Expression compileConstant(ParameterElement parameter) {
166 return buildConstant(glue.getConstantForVariable(parameter).value); 166 return buildConstant(glue.getConstantForVariable(parameter).value);
167 } 167 }
168 168
169 js.Expression buildStaticInvoke(Selector selector, 169 js.Expression buildStaticInvoke(Selector selector,
170 Element target, 170 Element target,
171 List<js.Expression> arguments) { 171 List<js.Expression> arguments) {
172 registry.registerStaticInvocation(target.declaration); 172 registry.registerStaticInvocation(target.declaration);
173
173 js.Expression elementAccess = glue.staticFunctionAccess(target); 174 js.Expression elementAccess = glue.staticFunctionAccess(target);
174 List<js.Expression> compiledArguments = 175 List<js.Expression> compiledArguments =
175 selector.makeArgumentsList(target.implementation, 176 selector.makeArgumentsList(target.implementation,
176 arguments, 177 arguments,
177 compileConstant); 178 compileConstant);
178 return new js.Call(elementAccess, compiledArguments); 179 return new js.Call(elementAccess, compiledArguments);
179 } 180 }
180 181
181 @override 182 @override
182 js.Expression visitInvokeConstructor(tree_ir.InvokeConstructor node) { 183 js.Expression visitInvokeConstructor(tree_ir.InvokeConstructor node) {
183 if (node.constant != null) return giveup(node); 184 if (node.constant != null) return giveup(node);
184 return buildStaticInvoke(node.selector, 185 return buildStaticInvoke(node.selector,
185 node.target, 186 node.target,
186 visitArguments(node.arguments)); 187 visitArguments(node.arguments));
187 } 188 }
188 189
189 void registerMethodInvoke(tree_ir.InvokeMethod node) { 190 void registerMethodInvoke(tree_ir.InvokeMethod node) {
190 Selector selector = node.selector; 191 Selector selector = node.selector;
191 // TODO(sigurdm): We should find a better place to register the call. 192 // TODO(sigurdm): We should find a better place to register the call.
192 Selector call = new Selector.callClosureFrom(selector); 193 Selector call = new Selector.callClosureFrom(selector);
193 registry.registerDynamicInvocation(call); 194 registry.registerDynamicInvocation(call);
194 registry.registerDynamicInvocation(selector); 195 registry.registerDynamicInvocation(selector);
195 } 196 }
196 197
197 @override 198 @override
198 js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) { 199 js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) {
200 // TODO(sigurdm): Handle intercepted invocations.
201 if (glue.isIntercepted(node.selector)) giveup(node);
202 js.Expression receiver = visitExpression(node.receiver);
203
204 List<js.Expression> arguments = visitArguments(node.arguments);
205
206 String methodName = glue.invocationName(node.selector);
199 registerMethodInvoke(node); 207 registerMethodInvoke(node);
200 return js.propertyCall(visitExpression(node.receiver), 208
201 glue.invocationName(node.selector), 209 return js.propertyCall(receiver, methodName, arguments);
202 visitArguments(node.arguments));
203 } 210 }
204 211
205 @override 212 @override
206 js.Expression visitInvokeStatic(tree_ir.InvokeStatic node) { 213 js.Expression visitInvokeStatic(tree_ir.InvokeStatic node) {
207 if (node.target is! FunctionElement) { 214 if (node.target is! FunctionElement) {
208 giveup(node, 'static getters and setters are not supported.'); 215 giveup(node, 'static getters and setters are not supported.');
209 } 216 }
210 return buildStaticInvoke(node.selector, 217 return buildStaticInvoke(node.selector,
211 node.target, 218 node.target,
212 visitArguments(node.arguments)); 219 visitArguments(node.arguments));
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 accumulator.add( 413 accumulator.add(
407 buildWhile(new js.LiteralBool(true), node.body, node.label, node)); 414 buildWhile(new js.LiteralBool(true), node.body, node.label, node));
408 } 415 }
409 416
410 @override 417 @override
411 void visitReturn(tree_ir.Return node) { 418 void visitReturn(tree_ir.Return node) {
412 accumulator.add(new js.Return(visitExpression(node.value))); 419 accumulator.add(new js.Return(visitExpression(node.value)));
413 } 420 }
414 421
415 } 422 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/dart_backend.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698