Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 808493002: Allow leveldb to use snappy in WebView. (Closed)

Created:
6 years ago by Torne
Modified:
6 years ago
Reviewers:
jsbell
CC:
chromium-reviews, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow leveldb to use snappy in WebView. Snappy was disabled for the WebView build to avoid introducing a new build dependency but snappy has been added to the WebView build for other purposes since then; we may as well re-enable it to remove a now unnecessary difference between the downstream webview build and regular builds of chromium for Android. BUG=236780 Committed: https://crrev.com/353779ec8f69d8666cac95bdf7c0a0ecbbbbee6b Cr-Commit-Position: refs/heads/master@{#308379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/leveldatabase/leveldatabase.gyp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Torne
6 years ago (2014-12-15 17:01:17 UTC) #2
jsbell
lgtm (cc: cmumford in case he sees further areas for simplification)
6 years ago (2014-12-15 17:27:11 UTC) #3
Torne
On 2014/12/15 17:27:11, jsbell wrote: > lgtm > > (cc: cmumford in case he sees ...
6 years ago (2014-12-15 17:27:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808493002/1
6 years ago (2014-12-15 17:29:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 18:54:40 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 18:56:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/353779ec8f69d8666cac95bdf7c0a0ecbbbbee6b
Cr-Commit-Position: refs/heads/master@{#308379}

Powered by Google App Engine
This is Rietveld 408576698