|
|
Chromium Code Reviews|
Created:
6 years ago by DaleCurtis Modified:
6 years ago CC:
chromium-reviews, piman+watch_chromium.org, Vangelis Kokkevis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable older intel drivers from gpu decode.
BUG=436968
TEST=none
Committed: https://crrev.com/fea87ea96145d070661bbbdf4d7e52ad44b061e7
Cr-Commit-Position: refs/heads/master@{#309085}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Update version. #Patch Set 3 : Remove trailing comma. #Messages
Total messages: 19 (6 generated)
dalecurtis@chromium.org changed reviewers: + zmo@chromium.org
dalecurtis@chromium.org changed reviewers: + vangelis@chromium.org
dalecurtis@chromium.org changed reviewers: + kbr@chromium.org - vangelis@chromium.org
Whoops, vangelis@ isn't actually an owner here, +kbr.
LGTM if this has been tested.
LGTM with nit. https://codereview.chromium.org/808483005/diff/1/gpu/config/software_renderin... File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/808483005/diff/1/gpu/config/software_renderin... gpu/config/software_rendering_list_json.cc:21: "version": "9.14", Nit: please update the version.
https://codereview.chromium.org/808483005/diff/1/gpu/config/software_renderin... File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/808483005/diff/1/gpu/config/software_renderin... gpu/config/software_rendering_list_json.cc:21: "version": "9.14", On 2014/12/17 21:13:03, Zhenyao Mo wrote: > Nit: please update the version. Should I use 9.15?
On 2014/12/17 21:14:49, DaleCurtis wrote: > https://codereview.chromium.org/808483005/diff/1/gpu/config/software_renderin... > File gpu/config/software_rendering_list_json.cc (right): > > https://codereview.chromium.org/808483005/diff/1/gpu/config/software_renderin... > gpu/config/software_rendering_list_json.cc:21: "version": "9.14", > On 2014/12/17 21:13:03, Zhenyao Mo wrote: > > Nit: please update the version. > > Should I use 9.15? Yes.
https://codereview.chromium.org/808483005/diff/1/gpu/config/software_renderin... File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/808483005/diff/1/gpu/config/software_renderin... gpu/config/software_rendering_list_json.cc:21: "version": "9.14", On 2014/12/17 21:14:49, DaleCurtis wrote: > On 2014/12/17 21:13:03, Zhenyao Mo wrote: > > Nit: please update the version. > > Should I use 9.15? Done.
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808483005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808483005/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/fea87ea96145d070661bbbdf4d7e52ad44b061e7 Cr-Commit-Position: refs/heads/master@{#309085} |
