Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 808483004: Instrumenting URLRequestJob::ReadRawDataHelper for jank. (Closed)

Created:
6 years ago by vadimt
Modified:
6 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumenting URLRequestJob::ReadRawDataHelper for jank. We know that URLRequestJob::ReadRawDataHelper causes 22.3 jph. Instrumenting further. BUG=423948 Committed: https://crrev.com/1031ed68dac91dfbd4752e36f07865df55621a3f Cr-Commit-Position: refs/heads/master@{#308661}

Patch Set 1 #

Total comments: 2

Patch Set 2 : mmenke comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M net/url_request/url_request_job.cc View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
vadimt
mmenke@, please review
6 years ago (2014-12-16 02:34:47 UTC) #2
mmenke
LGTM https://codereview.chromium.org/808483004/diff/1/net/url_request/url_request_job.cc File net/url_request/url_request_job.cc (right): https://codereview.chromium.org/808483004/diff/1/net/url_request/url_request_job.cc#newcode884 net/url_request/url_request_job.cc:884: network_delegate_->NotifyRawBytesRead(*request_, bytes_read); Just a note that this is ...
6 years ago (2014-12-16 16:20:25 UTC) #3
vadimt
https://codereview.chromium.org/808483004/diff/1/net/url_request/url_request_job.cc File net/url_request/url_request_job.cc (right): https://codereview.chromium.org/808483004/diff/1/net/url_request/url_request_job.cc#newcode884 net/url_request/url_request_job.cc:884: network_delegate_->NotifyRawBytesRead(*request_, bytes_read); On 2014/12/16 16:20:25, mmenke wrote: > Just ...
6 years ago (2014-12-16 18:47:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808483004/20001
6 years ago (2014-12-16 18:48:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-16 20:37:54 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-16 20:38:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1031ed68dac91dfbd4752e36f07865df55621a3f
Cr-Commit-Position: refs/heads/master@{#308661}

Powered by Google App Engine
This is Rietveld 408576698