Issue 808473003: [android_webview] Disable proguard for SystemWebViewGoogle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808473003: [android_webview] Disable proguard for SystemWebViewGoogle. (Closed)

Created:
6 years ago by mkosiba (inactive)

Modified:
6 years ago

Reviewers:
boliu

CC:
chromium-reviews, android-webview-reviews_chromium.org, Torne

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[android_webview] Disable proguard for SystemWebViewGoogle. We were using a stale proguard config which meant that Release builds were completely broken. Turning proguard off till we fix this for real. BUG=442348 Committed: https://crrev.com/40700e971f2fa39849df2316edadb9fb4ff6d0e1 Cr-Commit-Position: refs/heads/master@{#308380}

Patch Set 1 #

Patch Set 2 : #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	android_webview/apk/system_webview_apk_common.gypi	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808473003/20001

6 years ago (2014-12-15 17:13:50 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-15 18:56:35 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/40700e971f2fa39849df2316edadb9fb4ff6d0e1
Cr-Commit-Position: refs/heads/master@{#308380}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages