Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 808463002: Add SK_OVERRIDE to a few places that are missing it. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
tfarina, mtklein, *reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add SK_OVERRIDE to a few places that are missing it. This was done automatically by running clang-modernize -add-override -override-macros. It's not clear to me whether include/ is already clean or I just can't get the tool to work for headers. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e8307dc0d0a568775e64515a8fff7b2a709f0834

Patch Set 1 #

Patch Set 2 : gpu #

Patch Set 3 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M src/core/SkBlitter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 6 chunks +21 lines, -21 lines 0 comments Download
M src/core/SkImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRegion_path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkScan_Path.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkSpriteBlitter_ARGB32.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkSpriteBlitter_RGB16.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPathRendering.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
mtklein
6 years ago (2014-12-15 16:45:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808463002/40001
6 years ago (2014-12-15 16:46:09 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 16:46:10 UTC) #5
tfarina
lgtm
6 years ago (2014-12-15 16:50:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808463002/40001
6 years ago (2014-12-15 16:53:10 UTC) #11
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 16:53:10 UTC) #12
reed1
I have also been removing "virtual" when I've been doing this lately. Is that correct?
6 years ago (2014-12-15 17:04:09 UTC) #13
mtklein
On 2014/12/15 17:04:09, reed1 wrote: > I have also been removing "virtual" when I've been ...
6 years ago (2014-12-15 17:06:45 UTC) #14
reed1
lgtm
6 years ago (2014-12-15 17:06:48 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-15 17:08:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e8307dc0d0a568775e64515a8fff7b2a709f0834

Powered by Google App Engine
This is Rietveld 408576698