Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 808413004: Ship ES6 template literals (Closed)

Created:
6 years ago by arv (Not doing code reviews)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship ES6 template literals BUG=v8:3230 LOG=Y R=dslomov@chromium.org, caitpotter88@gmail.com Committed: https://crrev.com/6e888ca8644da706e746b44c512ec60113b14cfe Cr-Commit-Position: refs/heads/master@{#25892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -4 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
PTAL
6 years ago (2014-12-18 18:00:17 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years ago (2014-12-18 19:11:17 UTC) #2
caitp (gmail)
811113002 first imho :> lgtm
6 years ago (2014-12-18 19:13:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808413004/1
6 years ago (2014-12-18 19:44:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 20:11:43 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-18 20:12:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e888ca8644da706e746b44c512ec60113b14cfe
Cr-Commit-Position: refs/heads/master@{#25892}

Powered by Google App Engine
This is Rietveld 408576698