Issue 8084002: Start incremental marking on idle notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8084002: Start incremental marking on idle notification. (Closed)

Created:
9 years, 2 months ago by ulan

Modified:
8 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Start incremental marking on idle notification. Once marking is finished, perform global GC in the same way IdleNotification did before. BUG=v8:1458 TEST=cctest/test-heap/IdleNotificationAdvancesIncrementalMarking

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -0 lines)			Patch
M	src/heap.h	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+31 lines, -0 lines	1 comment	Download
M	src/incremental-marking.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

Please take a look, it is to be committed after the push to trunk.

9 years, 2 months ago (2011-09-29 16:07:55 UTC) #1

Vyacheslav Egorov (Chromium)

9 years, 2 months ago (2011-10-12 07:41:00 UTC) #2

lgtm

http://codereview.chromium.org/8084002/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/8084002/diff/1/src/heap.cc#newcode4545
src/heap.cc:4545: return incremental_marking()->IsComplete();
when it's complete it makes sense to do a finishing GC immediately without
giving JS chance to mutate anything.

Expand Messages | Collapse Messages