Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1471)

Issue 8084002: Start incremental marking on idle notification. (Closed)

Created:
9 years, 2 months ago by ulan
Modified:
8 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Start incremental marking on idle notification. Once marking is finished, perform global GC in the same way IdleNotification did before. BUG=v8:1458 TEST=cctest/test-heap/IdleNotificationAdvancesIncrementalMarking

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M src/heap.h View 2 chunks +13 lines, -0 lines 0 comments Download
M src/heap.cc View 2 chunks +31 lines, -0 lines 1 comment Download
M src/incremental-marking.h View 2 chunks +5 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
Please take a look, it is to be committed after the push to trunk.
9 years, 2 months ago (2011-09-29 16:07:55 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 2 months ago (2011-10-12 07:41:00 UTC) #2
lgtm

http://codereview.chromium.org/8084002/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/8084002/diff/1/src/heap.cc#newcode4545
src/heap.cc:4545: return incremental_marking()->IsComplete();
when it's complete it makes sense to do a finishing GC immediately without
giving JS chance to mutate anything.

Powered by Google App Engine
This is Rietveld 408576698