Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Issue 808373002: IDL: Simplify [TypeChecking=Interface] code generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
diff --git a/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp b/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
index 938aae779133efb5edd941cdc3c83fd0116ef3ab..dbe099944f882ef6896ef534eac41044f80c9483 100644
--- a/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
+++ b/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
@@ -96,11 +96,11 @@ static void promiseMethodPartialOverload3Method(const v8::FunctionCallbackInfo<v
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
Document* document;
{
- if (info.Length() > 0 && !V8Document::hasInstance(info[0], info.GetIsolate())) {
+ document = V8Document::toImplWithTypeCheck(info.GetIsolate(), info[0]);
+ if (!document) {
v8SetReturnValue(info, ScriptPromise::rejectRaw(info.GetIsolate(), V8ThrowException::createTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("promiseMethodPartialOverload", "TestInterface", "parameter 1 is not of type 'Document'."))));
return;
}
- document = V8Document::toImpl(v8::Handle<v8::Object>::Cast(info[0]));
}
v8SetReturnValue(info, TestPartialInterfaceImplementation3::promiseMethodPartialOverload(*impl, document).v8Value());
}
@@ -168,11 +168,11 @@ static void partial2VoidMethod3Method(const v8::FunctionCallbackInfo<v8::Value>&
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
Node* node;
{
- if (info.Length() > 0 && !V8Node::hasInstance(info[0], info.GetIsolate())) {
+ node = V8Node::toImplWithTypeCheck(info.GetIsolate(), info[0]);
+ if (!node) {
V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("partial2VoidMethod", "TestInterface", "parameter 1 is not of type 'Node'."));
return;
}
- node = V8Node::toImpl(v8::Handle<v8::Object>::Cast(info[0]));
}
TestPartialInterfaceImplementation3::partial2VoidMethod(*impl, node);
}

Powered by Google App Engine
This is Rietveld 408576698