Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 808373002: IDL: Simplify [TypeChecking=Interface] code generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_attributes.py
diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py
index add806fab987ce390c413976ce8abeef5881ff95..307fffb29a146de2f03345cfa5df768933205091 100644
--- a/Source/bindings/scripts/v8_attributes.py
+++ b/Source/bindings/scripts/v8_attributes.py
@@ -326,10 +326,6 @@ def setter_context(interface, attribute, context):
has_extended_attribute_value(attribute, 'TypeChecking', 'Interface')) and
idl_type.is_wrapper_type)
- type_checked = (has_type_checking_interface and
- # These allow null values, so a type-check is still required.
- not idl_type.is_nullable)
-
context.update({
'has_setter_exception_state':
is_setter_raises_exception or has_type_checking_interface or
@@ -343,8 +339,7 @@ def setter_context(interface, attribute, context):
'cppValue', isolate='scriptState->isolate()',
creation_context='scriptState->context()->Global()'),
'v8_value_to_local_cpp_value': idl_type.v8_value_to_local_cpp_value(
- extended_attributes, 'v8Value', 'cppValue',
- needs_type_check=not type_checked),
+ extended_attributes, 'v8Value', 'cppValue'),
})
# setter_expression() depends on context values we set above.
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698