Issue 808333005: [x86] Blacklist AVX for all Mac OS versions up to 10.9.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808333005: [x86] Blacklist AVX for all Mac OS versions up to 10.9. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer

Modified:
5 years, 11 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[x86] Blacklist AVX for all Mac OS versions up to 10.9. R=svenpanne@chromium.org Committed: https://crrev.com/05bcc2fbc62cd4ce5cf0c97a8d5eb42a4a5eb323 Cr-Commit-Position: refs/heads/master@{#25969}

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
	M	src/ia32/assembler-ia32.cc	View		2 chunks	+10 lines, -5 lines	1 comment	Download
	M	src/x64/assembler-x64.cc	View		2 chunks	+10 lines, -5 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with nits https://codereview.chromium.org/808333005/diff/1/src/ia32/assembler-ia32.cc File src/ia32/assembler-ia32.cc (right): https://codereview.chromium.org/808333005/diff/1/src/ia32/assembler-ia32.cc#newcode71 src/ia32/assembler-ia32.cc:71: // Make sure the buffer is ...

5 years, 11 months ago (2015-01-07 12:08:44 UTC) #3

Benedikt Meurer

Committed patchset #1 (id:1) manually as 05bcc2fbc62cd4ce5cf0c97a8d5eb42a4a5eb323 (presubmit successful).

5 years, 11 months ago (2015-01-07 12:11:00 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-07 12:11:03 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/05bcc2fbc62cd4ce5cf0c97a8d5eb42a4a5eb323
Cr-Commit-Position: refs/heads/master@{#25969}

Expand Messages | Collapse Messages