Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 808333004: virtual/override specifier cleanup in ui/ (mostly Ozone code). (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 11 months ago
Reviewers:
sky, spang
CC:
chromium-reviews, ozone-reviews_chromium.org, sadrul, tdresser+watch_chromium.org, Ian Vollick, dcheng, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

virtual/override specifier cleanup in ui/ (mostly Ozone code). These are changes detected by Chromecast not covered by the Linux build. See: https://codereview.chromium.org/831863003 R=sky@chromium.org,spang@chromium.org BUG=417463 Committed: https://crrev.com/0cffcfcc81a27345965a05ad0654d7d5ccd9eea9 Cr-Commit-Position: refs/heads/master@{#310019}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -118 lines) Patch
M ui/aura/test/ui_controls_factory_ozone.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M ui/aura/window_tree_host_ozone.h View 1 chunk +23 lines, -24 lines 0 comments Download
M ui/base/cursor/cursor_loader_ozone.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ui/base/cursor/ozone/bitmap_cursor_factory_ozone.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.h View 1 chunk +29 lines, -31 lines 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/layout/no/no_keyboard_layout_engine.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ui/events/ozone/layout/stub/stub_keyboard_layout_engine.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/public/input_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 11 months ago (2015-01-05 21:24:30 UTC) #1
spang
lgtm
5 years, 11 months ago (2015-01-05 21:26:17 UTC) #2
gunsch
On 2015/01/05 21:26:17, spang wrote: > lgtm Rebased, looks like https://codereview.chromium.org/785323005 pre-empted since my sync
5 years, 11 months ago (2015-01-05 21:30:33 UTC) #3
sky
LGTM
5 years, 11 months ago (2015-01-06 00:33:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808333004/20001
5 years, 11 months ago (2015-01-06 00:48:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 01:01:16 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 01:02:10 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0cffcfcc81a27345965a05ad0654d7d5ccd9eea9
Cr-Commit-Position: refs/heads/master@{#310019}

Powered by Google App Engine
This is Rietveld 408576698