Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 8083031: TcpClientSocketWin may detect EOF before the last asynchronous I/O (Closed)

Created:
9 years, 2 months ago by Takashi Toyoshima
Modified:
9 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

TcpClientSocketWin::IsConnected could detect EOF before the last received packet is returned via completion callback. BUG=98664 TEST=LayoutTests/http/tests/websocket/tests/hybi/close.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104852

Patch Set 1 #

Total comments: 2

Patch Set 2 : add same change for IsConnectedAndIdle() #

Patch Set 3 : checking just waiting_read_ is sufficient #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M net/socket/tcp_client_socket_win.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Takashi Toyoshima
Hi network guys, I found a bug on fundamental class. It seems to cause flakiness ...
9 years, 2 months ago (2011-09-30 12:48:28 UTC) #1
Takashi Toyoshima
trybot seems not to support new windows build path...
9 years, 2 months ago (2011-09-30 12:50:40 UTC) #2
wtc
http://codereview.chromium.org/8083031/diff/1/net/socket/tcp_client_socket_win.cc File net/socket/tcp_client_socket_win.cc (right): http://codereview.chromium.org/8083031/diff/1/net/socket/tcp_client_socket_win.cc#newcode593 net/socket/tcp_client_socket_win.cc:593: return true; Any change we make to TCPClientSocketWin::IsConnected should ...
9 years, 2 months ago (2011-09-30 19:02:38 UTC) #3
Takashi Toyoshima
As I wrote in BUG, another thread run callbacks. So, my change seems not to ...
9 years, 2 months ago (2011-10-01 15:14:03 UTC) #4
Takashi Toyoshima
DCHECK(CalledOnValidThread()) in DidCompleteRead() succeeded. So my previous change will be sufficient. I added the same ...
9 years, 2 months ago (2011-10-04 03:38:34 UTC) #5
willchan no longer on Chromium
I'm going to defer the review to Wan-Teh here, but FWIW, I approve of this ...
9 years, 2 months ago (2011-10-04 17:20:48 UTC) #6
wtc
LGTM. Thanks a lot for debugging this. In the CL's commit message, please change TcpClientSocketWin::IsConnected ...
9 years, 2 months ago (2011-10-04 20:59:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8083031/6002
9 years, 2 months ago (2011-10-11 03:40:33 UTC) #8
commit-bot: I haz the power
9 years, 2 months ago (2011-10-11 05:09:02 UTC) #9
Change committed as 104852

Powered by Google App Engine
This is Rietveld 408576698