ui/strings/translations/app_locale_settings_ko.xtb - Issue 808273002: Modernize CJK default font prefs on Mac/Windows/Linux

Side by Side Diff: ui/strings/translations/app_locale_settings_ko.xtb

Issue 808273002: Modernize CJK default font prefs on Mac/Windows/Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/app/resources/locale_settings_win.grd ('K') | « ui/strings/translations/app_locale_settings_ja.xtb ('k') | ui/strings/translations/app_locale_settings_zh-CN.xtb » ('j') | ui/strings/translations/app_locale_settings_zh-CN.xtb » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" ?>	1 <?xml version="1.0" ?>

2 <!DOCTYPE translationbundle>	2 <!DOCTYPE translationbundle>

3 <translationbundle lang="ko">	3 <translationbundle lang="ko">

4 <translation id="IDS_MINIMUM_UI_FONT_SIZE">10</translation>	4 <translation id="IDS_MINIMUM_UI_FONT_SIZE">10</translation>

5 <translation id="IDS_UI_FONT_FAMILY_CROS">Noto Sans UI,Noto Sans CJK KR,ui-sans, 13px</translation>	5 <translation id="IDS_UI_FONT_FAMILY_CROS">Noto Sans UI,Noto Sans CJK KR,ui-sans, 13px</translation>

6 <if expr="is_win">	6 <if expr="is_win">

7 <translation id="IDS_WEB_FONT_FAMILY">'Segoe UI',Arial,'Malgun Gothic',Gulim,s ans-serif</translation>	7 <translation id="IDS_WEB_FONT_FAMILY">'Segoe UI',Arial,'Malgun Gothic',Gulim,s ans-serif</translation>

8 <translation id="IDS_WEB_FONT_FAMILY_XP">Arial,'Malgun Gothic',Gulim,sans-seri f</translation>	8 <translation id="IDS_WEB_FONT_FAMILY_XP">Arial,'Malgun Gothic',Gulim,sans-seri f</translation>

9 </if>	9 </if>

10 <if expr="is_macosx or is_ios">	10 <if expr="is_macosx or is_ios">

11 <translation id="IDS_WEB_FONT_FAMILY">Helvetica,AppleGothic,sans-serif</transl ation>	11 <translation id="IDS_WEB_FONT_FAMILY">Helvetica,Apple SD Gothic Neo, AppleGoth ic,sans-serif</translation>
	Nico 2014/12/19 19:38:38 I understand this change I think: On OS X 10.8+, p I understand this change I think: On OS X 10.8+, people will get SD Gothic Neo, while on older systems it'll just fallback to old Gothic. But… jungshik at Google 2014/12/19 23:21:14 Yes, right Show quoted text On 2014/12/19 19:38:38, Nico wrote: > I understand this change I think: On OS X 10.8+, people will get SD Gothic Neo, > while on older systems it'll just fallback to old Gothic. But… Yes, right
12 </if>	12 </if>

13 <if expr="desktop_linux and not chromeos">	13 <if expr="desktop_linux and not chromeos">

14 <translation id="IDS_WEB_FONT_FAMILY">NanumGothic,UnDotum,Baekmuk Gulim,sans-s erif</translation>	14 <translation id="IDS_WEB_FONT_FAMILY">Noto Sans CJK KR,NanumGothic,sans-serif< /translation>
	Nico 2014/12/19 19:38:38 …what will happen on linux systems that don't have …what will happen on linux systems that don't have Noto Sans installed but do have e.g. UnDotum? Did you remove these intentionally? (This change isn't mentioned in the CL description) jungshik at Google 2014/12/19 23:21:14 I'm neutral. I can just keep it there. Recent (say Show quoted text On 2014/12/19 19:38:38, Nico wrote: > …what will happen on linux systems that don't have Noto Sans installed but do > have e.g. UnDotum? Did you remove these intentionally? (This change isn't > mentioned in the CL description) I'm neutral. I can just keep it there. Recent (say, 2012? or later) has NanumGothic. Yeah, keeping UnDotum wouldn't hurt anybody. I'll add it back.
15 </if>	15 </if>

16 <if expr="chromeos">	16 <if expr="chromeos">

17 <translation id="IDS_WEB_FONT_FAMILY">Noto Sans UI, Noto Sans CJK KR, sans-ser if</translation>	17 <translation id="IDS_WEB_FONT_FAMILY">Noto Sans UI, Noto Sans CJK KR, sans-ser if</translation>

18 </if>	18 </if>

19 </translationbundle>	19 </translationbundle>

OLD	NEW