chrome/browser/ui/navigation_correction_tab_observer.cc - Issue 808253006: Remove the GoogleURLTracker infobar functionality entirely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/navigation_correction_tab_observer.cc

Issue 808253006: Remove the GoogleURLTracker infobar functionality entirely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/google/google_url_tracker_factory.cc ('K') | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | components/google/core/browser/google_url_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/navigation_correction_tab_observer.cc

diff --git a/chrome/browser/ui/navigation_correction_tab_observer.cc b/chrome/browser/ui/navigation_correction_tab_observer.cc

index 53c4326eba69c179785c918010b0668ac030acde..d59f3e9eff0439fbc43389781a59a9fb3f75dc02 100644

--- a/chrome/browser/ui/navigation_correction_tab_observer.cc

+++ b/chrome/browser/ui/navigation_correction_tab_observer.cc

@@ -41,6 +41,10 @@ NavigationCorrectionTabObserver::NavigationCorrectionTabObserver(

GoogleURLTracker* google_url_tracker =

GoogleURLTrackerFactory::GetForProfile(profile_);

if (google_url_tracker) {

+ if (google_util::IsGoogleDomainUrl(GetNavigationCorrectionURL(),

+ google_util::ALLOW_SUBDOMAIN,

+ google_util::ALLOW_NON_STANDARD_PORTS))

+ google_url_tracker->RequestServerCheck(false);

Peter Kasting 2014/12/20 02:18:07 This is a seeming omission I noticed while cleanin

google_url_updated_subscription_ = google_url_tracker->RegisterCallback(

base::Bind(&NavigationCorrectionTabObserver::OnGoogleURLUpdated,

base::Unretained(this)));