Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/google/google_url_tracker_factory.cc

Issue 808253006: Remove the GoogleURLTracker infobar functionality entirely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile fixes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/google/google_url_tracker_factory.h" 5 #include "chrome/browser/google/google_url_tracker_factory.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/google/chrome_google_url_tracker_client.h" 8 #include "chrome/browser/google/chrome_google_url_tracker_client.h"
9 #include "chrome/browser/profiles/incognito_helpers.h" 9 #include "chrome/browser/profiles/incognito_helpers.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
11 #include "components/google/core/browser/google_pref_names.h" 11 #include "components/google/core/browser/google_pref_names.h"
12 #include "components/google/core/browser/google_url_tracker.h" 12 #include "components/google/core/browser/google_url_tracker.h"
13 #include "components/keyed_service/content/browser_context_dependency_manager.h" 13 #include "components/keyed_service/content/browser_context_dependency_manager.h"
14 #include "components/pref_registry/pref_registry_syncable.h" 14 #include "components/pref_registry/pref_registry_syncable.h"
15 15
16 namespace {
17
18 const char kLastPromptedGoogleURL[] = "browser.last_prompted_google_url";
19
20 } // namespace
21
16 22
17 // static 23 // static
18 GoogleURLTracker* GoogleURLTrackerFactory::GetForProfile(Profile* profile) { 24 GoogleURLTracker* GoogleURLTrackerFactory::GetForProfile(Profile* profile) {
19 return static_cast<GoogleURLTracker*>( 25 return static_cast<GoogleURLTracker*>(
20 GetInstance()->GetServiceForBrowserContext(profile, true)); 26 GetInstance()->GetServiceForBrowserContext(profile, true));
21 } 27 }
22 28
23 // static 29 // static
24 GoogleURLTrackerFactory* GoogleURLTrackerFactory::GetInstance() { 30 GoogleURLTrackerFactory* GoogleURLTrackerFactory::GetInstance() {
25 return Singleton<GoogleURLTrackerFactory>::get(); 31 return Singleton<GoogleURLTrackerFactory>::get();
26 } 32 }
27 33
28 GoogleURLTrackerFactory::GoogleURLTrackerFactory() 34 GoogleURLTrackerFactory::GoogleURLTrackerFactory()
29 : BrowserContextKeyedServiceFactory( 35 : BrowserContextKeyedServiceFactory(
30 "GoogleURLTracker", 36 "GoogleURLTracker",
31 BrowserContextDependencyManager::GetInstance()) { 37 BrowserContextDependencyManager::GetInstance()) {
32 } 38 }
33 39
34 GoogleURLTrackerFactory::~GoogleURLTrackerFactory() { 40 GoogleURLTrackerFactory::~GoogleURLTrackerFactory() {
35 } 41 }
36 42
37 KeyedService* GoogleURLTrackerFactory::BuildServiceInstanceFor( 43 KeyedService* GoogleURLTrackerFactory::BuildServiceInstanceFor(
38 content::BrowserContext* context) const { 44 content::BrowserContext* context) const {
45 // Delete this now-unused pref.
46 // At some point in the future, this code can be removed entirely.
47 static_cast<Profile*>(context)->GetOriginalProfile()->GetPrefs()->ClearPref(
48 kLastPromptedGoogleURL);
Peter Kasting 2014/12/20 02:18:07 I think this is the right way to delete this pref?
49
39 scoped_ptr<GoogleURLTrackerClient> client( 50 scoped_ptr<GoogleURLTrackerClient> client(
40 new ChromeGoogleURLTrackerClient(Profile::FromBrowserContext(context))); 51 new ChromeGoogleURLTrackerClient(Profile::FromBrowserContext(context)));
41 return new GoogleURLTracker(client.Pass(), GoogleURLTracker::NORMAL_MODE); 52 return new GoogleURLTracker(client.Pass(), GoogleURLTracker::NORMAL_MODE);
42 } 53 }
43 54
44 void GoogleURLTrackerFactory::RegisterProfilePrefs( 55 void GoogleURLTrackerFactory::RegisterProfilePrefs(
45 user_prefs::PrefRegistrySyncable* user_prefs) { 56 user_prefs::PrefRegistrySyncable* user_prefs) {
46 user_prefs->RegisterStringPref( 57 user_prefs->RegisterStringPref(
47 prefs::kLastKnownGoogleURL, 58 prefs::kLastKnownGoogleURL,
48 GoogleURLTracker::kDefaultGoogleHomepage, 59 GoogleURLTracker::kDefaultGoogleHomepage,
49 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 60 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
50 user_prefs->RegisterStringPref( 61 user_prefs->RegisterStringPref(
51 prefs::kLastPromptedGoogleURL, 62 kLastPromptedGoogleURL,
52 std::string(), 63 std::string(),
53 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 64 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
54 } 65 }
55 66
56 content::BrowserContext* GoogleURLTrackerFactory::GetBrowserContextToUse( 67 content::BrowserContext* GoogleURLTrackerFactory::GetBrowserContextToUse(
57 content::BrowserContext* context) const { 68 content::BrowserContext* context) const {
58 return chrome::GetBrowserContextRedirectedInIncognito(context); 69 return chrome::GetBrowserContextRedirectedInIncognito(context);
59 } 70 }
60 71
61 bool GoogleURLTrackerFactory::ServiceIsCreatedWithBrowserContext() const { 72 bool GoogleURLTrackerFactory::ServiceIsCreatedWithBrowserContext() const {
62 return true; 73 return true;
63 } 74 }
64 75
65 bool GoogleURLTrackerFactory::ServiceIsNULLWhileTesting() const { 76 bool GoogleURLTrackerFactory::ServiceIsNULLWhileTesting() const {
66 return true; 77 return true;
67 } 78 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698