Remove the GoogleURLTracker infobar functionality entirely.

chrome/browser/ui/navigation_correction_tab_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/navigation_correction_tab_observer.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/google/google_profile_helper.h"
@@ skipping 23 matching lines @@
     pref_change_registrar_.Init(prefs);
     pref_change_registrar_.Add(
         prefs::kAlternateErrorPagesEnabled,
         base::Bind(&NavigationCorrectionTabObserver::OnEnabledChanged,
                    base::Unretained(this)));
   }
 
   GoogleURLTracker* google_url_tracker =
       GoogleURLTrackerFactory::GetForProfile(profile_);
   if (google_url_tracker) {
+    if (google_util::IsGoogleDomainUrl(GetNavigationCorrectionURL(),

[mmenke, 2015/01/05 15:35:51]

It's possible that navigation corrections are disabled.  If multiple
RequestServerCheck(false) calls don't result in lots of redundant checks, could
we move this into NavigationCorrectionTabObserver::GetNavigationCorrectionURL,
and only do it just above the "google_util::LinkDoctorBaseURL" call?

Would still be best if we could cancel the registration if the option is later
disabled, but only ever requesting checks if it's enabled at some point during
chrome's execution seems better than nothing.

[mmenke, 2015/01/05 15:35:51]

Think this needs a comment.

[Peter Kasting, 2015/01/05 20:15:47]

They won't result in redundant checks, but moving this there means we could
return the wrong domain from at least the first call to that function, since the
check (obviously) completes asynchronously.

OTOH, I think if someone starts with corrections disabled, then later enables
them, it won't necessarily cause us to do a server check.  So maybe we should
have something like this in both places.
Yeah, the chance of turning off corrections + then seeing a network change or
something similar that would actually trigger another check seems low enough to
not really worry about.

[Peter Kasting, 2015/01/05 20:15:47]

What would you propose?  (The code seems pretty clear to me so I'm not sure what
you'd like clarified.)

[mmenke, 2015/01/05 21:01:53]

I'd suggest "// If navigation corrections will be retrieved from Google, need to
get the correct Google domain to use."

I think neither "google_url_tracker" nor "RequestServerCheck" are particularly
clear.  I would have guessed google url tracker was for separating out full
Google URLs used by Chrome and not Chromium, rather than for figuring out which
Google domain to use, and checking a server sounds more like checking it a
server is servicing requests to me...  Which left me rather confused when
reading this code, until I looked at the comments in the relevant file.

[mmenke, 2015/01/05 21:01:53]

Something in both places seems reasonable (Or something here and in
NavigationCorrectionTabObserver::OnEnabledChanged, actually).

+                                       google_util::ALLOW_SUBDOMAIN,
+                                       google_util::ALLOW_NON_STANDARD_PORTS))
+      google_url_tracker->RequestServerCheck(false);
     google_url_updated_subscription_ = google_url_tracker->RegisterCallback(
         base::Bind(&NavigationCorrectionTabObserver::OnGoogleURLUpdated,
                    base::Unretained(this)));
   }
 }
 
 NavigationCorrectionTabObserver::~NavigationCorrectionTabObserver() {
 }
 
 // static
@@ skipping 40 matching lines @@
   rfh->Send(new ChromeViewMsg_SetNavigationCorrectionInfo(
       rfh->GetRoutingID(),
       GetNavigationCorrectionURL(),
       google_util::GetGoogleLocale(g_browser_process->GetApplicationLocale()),
       google_util::GetGoogleCountryCode(
           google_profile_helper::GetGoogleHomePageURL(profile_)),
       google_apis::GetAPIKey(),
       google_util::GetGoogleSearchURL(
           google_profile_helper::GetGoogleHomePageURL(profile_))));
 }