chrome/browser/google/DEPS - Issue 808253006: Remove the GoogleURLTracker infobar functionality entirely.

Side by Side Diff: chrome/browser/google/DEPS

Issue 808253006: Remove the GoogleURLTracker infobar functionality entirely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix size_t -> int conversion (since I turned off the warning disable for it) Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc ('k') | chrome/browser/google/chrome_google_url_tracker_client.h » ('j') | chrome/browser/ui/navigation_correction_tab_observer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 specific_include_rules = {	1 specific_include_rules = {

2 # GoogleURLTracker can't use WebContents, since it is used by iOS.	2 # GoogleURLTracker can't use WebContents, since it is used by iOS.

3 # If WebContents functionality is needed, add it to

4 # GoogleURLTrackerNavigationHelperImpl.

5 'google_url_tracker\.': [	3 'google_url_tracker\.': [

6 "-content/public/browser/web_contents.h",	4 "-content/public/browser/web_contents.h",

7 ],	5 ],
	Ilya Sherman 2015/01/06 00:36:28 Is any of this still needed now that the code has Is any of this still needed now that the code has been componentized? Peter Kasting 2015/01/06 00:54:26 Can you clarify what the "now that the code has be Show quoted text On 2015/01/06 00:36:28, Ilya Sherman wrote: > Is any of this still needed now that the code has been componentized? Can you clarify what the "now that the code has been componentized" part means? AFAIK this file was added when the code was componentized so I'm not sure what's changed that you're referring to. I assume that iOS is still using this class and thus that we still want to protect against use of web_contents.h, but I don't think I added this to begin with so I'm not really the expert. Ilya Sherman 2015/01/06 01:19:35 I guess to be clearer, this rule seems to now only Show quoted text On 2015/01/06 00:54:26, Peter Kasting wrote: > On 2015/01/06 00:36:28, Ilya Sherman wrote: > > Is any of this still needed now that the code has been componentized? > > Can you clarify what the "now that the code has been componentized" part means? > AFAIK this file was added when the code was componentized so I'm not sure what's > changed that you're referring to. > > I assume that iOS is still using this class and thus that we still want to > protect against use of web_contents.h, but I don't think I added this to begin > with so I'm not really the expert. I guess to be clearer, this rule seems to now only apply to the google_url_tracker_factory.* files, which I don't think are used on iOS. It would be good to double-check with the iOS team, but I'm pretty sure that this entire DEPS file can be removed. Peter Kasting 2015/01/06 01:27:51 Never mind, I was misunderstanding some things (an Show quoted text On 2015/01/06 01:19:35, Ilya Sherman wrote: > On 2015/01/06 00:54:26, Peter Kasting wrote: > > On 2015/01/06 00:36:28, Ilya Sherman wrote: > > > Is any of this still needed now that the code has been componentized? > > > > Can you clarify what the "now that the code has been componentized" part > means? > > AFAIK this file was added when the code was componentized so I'm not sure > what's > > changed that you're referring to. > > > > I assume that iOS is still using this class and thus that we still want to > > protect against use of web_contents.h, but I don't think I added this to begin > > with so I'm not really the expert. > > I guess to be clearer, this rule seems to now only apply to the > google_url_tracker_factory.* files, which I don't think are used on iOS. It > would be good to double-check with the iOS team, but I'm pretty sure that this > entire DEPS file can be removed. Never mind, I was misunderstanding some things (and I think you are too -- "google_url_tracker\." won't match against "google_url_tracker_factory.*"). This file is dead and has been dead since componentization. I'll remove it.
8 }	6 }

OLD	NEW