Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: ui/aura/window.h

Issue 8082017: Change Window visibility to a simple boolean for now. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/desktop.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window.h
===================================================================
--- ui/aura/window.h (revision 103502)
+++ ui/aura/window.h (working copy)
@@ -44,18 +44,6 @@
public:
typedef std::vector<Window*> Windows;
- enum Visibility {
- // Don't display the window onscreen and don't let it receive mouse
- // events. This is the default.
- VISIBILITY_HIDDEN = 1,
-
- // Display the window and let it receive mouse events.
- VISIBILITY_SHOWN = 2,
-
- // Display the window but prevent it from receiving mouse events.
- VISIBILITY_SHOWN_NO_INPUT = 3,
- };
-
explicit Window(WindowDelegate* delegate);
~Window();
@@ -71,8 +59,9 @@
const ui::Layer* layer() const { return layer_.get(); }
// Changes the visibility of the window.
- void SetVisibility(Visibility visibility);
- Visibility visibility() const { return visibility_; }
+ void Show();
+ void Hide();
+ bool visible() const { return visible_; }
// Assigns a LayoutManager to size and place child windows.
// The Window takes ownership of the LayoutManager.
@@ -165,6 +154,10 @@
virtual internal::RootWindow* GetRoot();
private:
+ // Updates the visible state of the layer, but does not make visible-state
+ // specific changes. Called from Show()/Hide().
+ void SetVisible(bool visible);
+
// Schedules a paint for the Window's entire bounds.
void SchedulePaint();
@@ -173,7 +166,7 @@
WindowDelegate* delegate_;
- Visibility visibility_;
+ bool visible_;
scoped_ptr<ui::Layer> layer_;
« no previous file with comments | « ui/aura/desktop.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698