chrome/browser/history/history_backend.h - Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend.h

Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated patch for android port Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/provider/chrome_browser_provider.cc ('K') | « chrome/browser/chrome_notification_types.h ('k') | chrome/browser/history/history_backend.cc » ('j') | chrome/browser/history/history_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_backend.h

diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h

index d0987e541af75e6c71a21cf38c88aa38b9cbf99b..00b04b219d116fd64a6d3c97f65db45e0763a9b0 100644

--- a/chrome/browser/history/history_backend.h

+++ b/chrome/browser/history/history_backend.h

@@ -143,6 +143,11 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

// be forwarded to the HistoryServiceObservers in the correct thread.

virtual void NotifyURLsModified(const URLRows& changed_urls) = 0;

+ virtual void NotifyHistoryKeywordSearchTermUpdated(

sdefresne 2014/12/24 09:03:43 style: please comment this method

Abhishek 2014/12/24 19:39:41 Done.

+ const URLRow& row,

+ KeywordID keyword_id,

+ const base::string16& term) = 0;

// Broadcasts the specified notification to the notification service.

// This is implemented here because notifications must only be sent from

// the main thread. This is the only method that doesn't identify the