Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/history/history_service.h

Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update unittest Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 // modified. |changed_urls| contains the list of affects URLs. 609 // modified. |changed_urls| contains the list of affects URLs.
610 void NotifyURLsModified(const history::URLRows& changed_urls); 610 void NotifyURLsModified(const history::URLRows& changed_urls);
611 611
612 // Notify all HistoryServiceObservers registered that the 612 // Notify all HistoryServiceObservers registered that the
613 // HistoryService has finished loading. 613 // HistoryService has finished loading.
614 void NotifyHistoryServiceLoaded(); 614 void NotifyHistoryServiceLoaded();
615 615
616 // HistoryService is being deleted. 616 // HistoryService is being deleted.
617 void NotifyHistoryServiceBeingDeleted(); 617 void NotifyHistoryServiceBeingDeleted();
618 618
619 // Notify all HistoryServiceObservers registered that a keyword search term
620 // has been updated. |row| contains the URL information for search |term|.
621 // |keyword_id| associated with a URL and search term.
622 void NotifyKeywordSearchTermUpdated(const history::URLRow& row,
623 history::KeywordID keyword_id,
624 const base::string16& term);
625
619 // Favicon ------------------------------------------------------------------- 626 // Favicon -------------------------------------------------------------------
620 627
621 // These favicon methods are exposed to the FaviconService. Instead of calling 628 // These favicon methods are exposed to the FaviconService. Instead of calling
622 // these methods directly you should call the respective method on the 629 // these methods directly you should call the respective method on the
623 // FaviconService. 630 // FaviconService.
624 631
625 // Used by FaviconService to get the favicon bitmaps from the history backend 632 // Used by FaviconService to get the favicon bitmaps from the history backend
626 // whose edge sizes most closely match |desired_sizes| for |icon_types|. If 633 // whose edge sizes most closely match |desired_sizes| for |icon_types|. If
627 // |desired_sizes| has a '0' entry, the largest favicon bitmap for 634 // |desired_sizes| has a '0' entry, the largest favicon bitmap for
628 // |icon_types| is returned. The returned FaviconBitmapResults will have at 635 // |icon_types| is returned. The returned FaviconBitmapResults will have at
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
906 913
907 history::DeleteDirectiveHandler delete_directive_handler_; 914 history::DeleteDirectiveHandler delete_directive_handler_;
908 915
909 // All vended weak pointers are invalidated in Cleanup(). 916 // All vended weak pointers are invalidated in Cleanup().
910 base::WeakPtrFactory<HistoryService> weak_ptr_factory_; 917 base::WeakPtrFactory<HistoryService> weak_ptr_factory_;
911 918
912 DISALLOW_COPY_AND_ASSIGN(HistoryService); 919 DISALLOW_COPY_AND_ASSIGN(HistoryService);
913 }; 920 };
914 921
915 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 922 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/history_notifications.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698