Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED

chrome/browser/history/in_memory_history_backend.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The InMemoryHistoryBackend is a wrapper around the in-memory URL database.
 // It maintains an in-memory cache of a subset of history that is required for
 // low-latency operations, such as in-line autocomplete.
 //
 // The in-memory cache provides the following guarantees:
 //  (1.) It will always contain URLRows that either have a |typed_count| > 0; or
@@ skipping 23 matching lines @@
 class HistoryService;
 class Profile;
 
 namespace base {
 class FilePath;
 }
 
 namespace history {
 
 class InMemoryDatabase;
 struct KeywordSearchUpdatedDetails;

[sdefresne, 2014/12/24 09:03:43]

KeywordSearchUpdatedDetails is not used anywhere, please remove:
- this forward-declaration,
- type declaration and implementation in
chrome/browser/history/history_notifications.{cc,h}

[Abhishek, 2014/12/24 19:39:41]

Done.

 struct KeywordSearchDeletedDetails;
 class URLDatabase;
 class URLRow;
 struct URLsDeletedDetails;
 struct URLsModifiedDetails;
 
 class InMemoryHistoryBackend : public HistoryServiceObserver,
                                public content::NotificationObserver {
  public:
   InMemoryHistoryBackend();
@@ skipping 20 matching lines @@
   }
 
   // HistoryServiceObserver:
   void OnURLVisited(HistoryService* history_service,
                     ui::PageTransition transition,
                     const URLRow& row,
                     const RedirectList& redirects,
                     base::Time visit_time) override;
   void OnURLsModified(HistoryService* history_service,
                       const URLRows& changed_urls) override;
 

[sdefresne, 2014/12/24 09:03:43]

nit: remove empty line

[Abhishek, 2014/12/24 19:39:41]

Done.

+  void HistoryKeywordSearchTermUpdated(HistoryService* history_service,
+                                       const URLRow& row,
+                                       KeywordID keyword_id,
+                                       const base::string16& term) override;
+
   // Notification callback.
   void Observe(int type,
                const content::NotificationSource& source,
                const content::NotificationDetails& details) override;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, DeleteAll);
 
   // Handler for HISTORY_URL_VISITED and HISTORY_URLS_MODIFIED.
   void OnURLVisitedOrModified(const URLRow& url_row);
 
   // Handler for HISTORY_URLS_DELETED.
   void OnURLsDeleted(const URLsDeletedDetails& details);
 
   // Handler for HISTORY_KEYWORD_SEARCH_TERM_UPDATED.
-  void OnKeywordSearchTermUpdated(const KeywordSearchUpdatedDetails& details);
+  void OnKeywordSearchTermUpdated(const URLRow& row,
+                                  KeywordID keyword_id,
+                                  const base::string16& term);
 
   // Handler for HISTORY_KEYWORD_SEARCH_TERM_DELETED.
   void OnKeywordSearchTermDeleted(const KeywordSearchDeletedDetails& details);
 
   content::NotificationRegistrar registrar_;
 
   scoped_ptr<InMemoryDatabase> db_;
 
   // The profile that this object is attached. May be NULL before
   // initialization.
   Profile* profile_;
   ScopedObserver<HistoryService, HistoryServiceObserver>
       history_service_observer_;
   HistoryService* history_service_;
 
   DISALLOW_COPY_AND_ASSIGN(InMemoryHistoryBackend);
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_IN_MEMORY_HISTORY_BACKEND_H_