Issue 808053006: Make --gdb work again by using gdbserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808053006: Make --gdb work again by using gdbserver (Closed)

Created:
5 years, 11 months ago by eseidel

Modified:
5 years, 11 months ago

Reviewers:
qsr, abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make --gdb work again by using gdbserver --gdb now starts gdbserver and I've added a new command gdb_attach which knows how to launch gdb and connect to the launched gdbserver This doesn't quite work on android yet, but it's very close. R=abarth@chromium.org, qsr@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/4656d85f590e4776eacd1b020b37d2df83a1e829

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -14 lines)			Patch
	M	sky/tools/skydb	View		7 chunks	+49 lines, -14 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

https://codereview.chromium.org/808053006/diff/1/sky/tools/skydb File sky/tools/skydb (right): https://codereview.chromium.org/808053006/diff/1/sky/tools/skydb#newcode226 sky/tools/skydb:226: if 'remote_sky_server_port' in self.pids: This was just checking for ...

5 years, 11 months ago (2015-01-13 20:11:32 UTC) #2

eseidel

5 years, 11 months ago (2015-01-13 20:16:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4656d85f590e4776eacd1b020b37d2df83a1e829 (presubmit successful).

Expand Messages | Collapse Messages