Issue 808053003: Oilpan: remove unused typed pointer cast operation over (Weak)Member.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808053003: Oilpan: remove unused typed pointer cast operation over (Weak)Member. (Closed)

Created:
5 years, 11 months ago by sof

Modified:
5 years, 11 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: remove unused typed pointer cast operation over (Weak)Member. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187809

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	Source/platform/heap/Handle.h	View		2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. No good reason not to retire these, I suppose.

5 years, 11 months ago (2014-12-31 10:52:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808053003/1

5 years, 11 months ago (2014-12-31 13:22:28 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187809

5 years, 11 months ago (2014-12-31 15:00:22 UTC) #6

haraken

5 years, 11 months ago (2014-12-31 15:02:03 UTC) #7

Message was sent while issue was closed.

On 2014/12/31 15:00:22, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=187809

This is the first commit of 2015 in JST, as far as I know :)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages