Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: ui/compositor/compositor.cc

Issue 808003002: Fix compositor integration in ui/compositor (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/compositor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/compositor.cc
diff --git a/ui/compositor/compositor.cc b/ui/compositor/compositor.cc
index 7fd7fe90317dc3f9783d0313c676f8ba41d4d550..277acd9fb3eb941c1afff059dd65c8d0b3ca47fa 100644
--- a/ui/compositor/compositor.cc
+++ b/ui/compositor/compositor.cc
@@ -203,6 +203,10 @@ Compositor::~Compositor() {
context_factory_->RemoveCompositor(this);
}
+void Compositor::SetOutputSurface(scoped_ptr<cc::OutputSurface> surface) {
+ host_->SetOutputSurface(surface.Pass());
+}
+
void Compositor::ScheduleDraw() {
if (compositor_thread_loop_.get()) {
host_->SetNeedsCommit();
@@ -215,20 +219,10 @@ void Compositor::ScheduleDraw() {
}
void Compositor::DidInitializeOutputSurface() {
- num_failed_recreate_attempts_ = 0;
}
void Compositor::DidFailToInitializeOutputSurface() {
- num_failed_recreate_attempts_++;
-
- // Tolerate a certain number of recreation failures to work around races
- // in the output-surface-lost machinery.
- if (num_failed_recreate_attempts_ >= MAX_OUTPUT_SURFACE_RETRIES)
- LOG(FATAL) << "Failed to create a fallback OutputSurface.";
-
- base::MessageLoop::current()->PostTask(
- FROM_HERE, base::Bind(&Compositor::RequestNewOutputSurface,
- weak_ptr_factory_.GetWeakPtr()));
+ NOTREACHED() << "We don't support fallback";
}
void Compositor::SetRootLayer(Layer* root_layer) {
@@ -385,9 +379,8 @@ void Compositor::Layout() {
}
void Compositor::RequestNewOutputSurface() {
- bool fallback =
- num_failed_recreate_attempts_ >= OUTPUT_SURFACE_RETRIES_BEFORE_FALLBACK;
- context_factory_->CreateOutputSurface(weak_ptr_factory_.GetWeakPtr().get(),
+ bool fallback = false;
+ context_factory_->CreateOutputSurface(weak_ptr_factory_.GetWeakPtr(),
fallback);
}
« no previous file with comments | « ui/compositor/compositor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698